From: Jaehoon Chung <jh80.chung@samsung.com>
To: Grant Grundler <grundler@chromium.org>,
Chris Ball <cjb@laptop.org>,
Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
Seungwon Jeon <tgih.jun@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Sonny Rao <sonnyrao@chromium.org>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: dw_mmc: priv->sdr_timing set wrong
Date: Tue, 22 Oct 2013 15:45:42 +0900 [thread overview]
Message-ID: <52661F16.3080602@samsung.com> (raw)
In-Reply-To: <CANEJEGt+kx3_EjgBGxkZ9TJec9ngf=FOcwhg2+eAtPY9-2xxCA@mail.gmail.com>
Hi Grant,
Good catch..sdr-timing is set to wrong value.(set to ddr-timing)
Do you have the plan that send the fixing patch at mailing?
Best Regards,
Jaehoon Chung
On 10/19/2013 05:13 AM, Grant Grundler wrote:
> Chris, Yuvaraj, Alim, Jaehoon,
>
> This patch is wrong:
> https://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?h=mmc-next&id=e6c784eded7b39caeaf2e9206336fa1daeccfd09
>
> sdr_timing needs to come from the of_property "samsung,dw-mshc-sdr-timing".
> Assignment of priv->sdr_timing needs to move back where it was before.
>
> Can one of you guys "just fix it" or do you need a patch from me (or Sonny)?
>
> (This came up during my review of eMMC patches that sonny is
> backporting to ChromeOS-3.8 kernel and I'm not done yet - have a ton
> more to do here.)
>
> thanks,
> grant
>
next prev parent reply other threads:[~2013-10-22 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 20:13 dw_mmc: priv->sdr_timing set wrong Grant Grundler
2013-10-22 6:45 ` Jaehoon Chung [this message]
2013-10-22 8:32 ` Yuvaraj Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52661F16.3080602@samsung.com \
--to=jh80.chung@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=grundler@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.