* dw_mmc: priv->sdr_timing set wrong
@ 2013-10-18 20:13 Grant Grundler
2013-10-22 6:45 ` Jaehoon Chung
0 siblings, 1 reply; 3+ messages in thread
From: Grant Grundler @ 2013-10-18 20:13 UTC (permalink / raw)
To: Chris Ball, Jaehoon Chung, Yuvaraj Kumar C D, Seungwon Jeon
Cc: linux-mmc@vger.kernel.org, Sonny Rao, ALIM AKHTAR,
Douglas Anderson
Chris, Yuvaraj, Alim, Jaehoon,
This patch is wrong:
https://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?h=mmc-next&id=e6c784eded7b39caeaf2e9206336fa1daeccfd09
sdr_timing needs to come from the of_property "samsung,dw-mshc-sdr-timing".
Assignment of priv->sdr_timing needs to move back where it was before.
Can one of you guys "just fix it" or do you need a patch from me (or Sonny)?
(This came up during my review of eMMC patches that sonny is
backporting to ChromeOS-3.8 kernel and I'm not done yet - have a ton
more to do here.)
thanks,
grant
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: dw_mmc: priv->sdr_timing set wrong
2013-10-18 20:13 dw_mmc: priv->sdr_timing set wrong Grant Grundler
@ 2013-10-22 6:45 ` Jaehoon Chung
2013-10-22 8:32 ` Yuvaraj Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2013-10-22 6:45 UTC (permalink / raw)
To: Grant Grundler, Chris Ball, Yuvaraj Kumar C D, Seungwon Jeon
Cc: linux-mmc@vger.kernel.org, Sonny Rao, ALIM AKHTAR,
Douglas Anderson
Hi Grant,
Good catch..sdr-timing is set to wrong value.(set to ddr-timing)
Do you have the plan that send the fixing patch at mailing?
Best Regards,
Jaehoon Chung
On 10/19/2013 05:13 AM, Grant Grundler wrote:
> Chris, Yuvaraj, Alim, Jaehoon,
>
> This patch is wrong:
> https://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?h=mmc-next&id=e6c784eded7b39caeaf2e9206336fa1daeccfd09
>
> sdr_timing needs to come from the of_property "samsung,dw-mshc-sdr-timing".
> Assignment of priv->sdr_timing needs to move back where it was before.
>
> Can one of you guys "just fix it" or do you need a patch from me (or Sonny)?
>
> (This came up during my review of eMMC patches that sonny is
> backporting to ChromeOS-3.8 kernel and I'm not done yet - have a ton
> more to do here.)
>
> thanks,
> grant
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: dw_mmc: priv->sdr_timing set wrong
2013-10-22 6:45 ` Jaehoon Chung
@ 2013-10-22 8:32 ` Yuvaraj Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Yuvaraj Kumar @ 2013-10-22 8:32 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Grant Grundler, Chris Ball, Seungwon Jeon,
linux-mmc@vger.kernel.org, Sonny Rao, ALIM AKHTAR,
Douglas Anderson
On Tue, Oct 22, 2013 at 12:15 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Grant,
>
> Good catch..sdr-timing is set to wrong value.(set to ddr-timing)
> Do you have the plan that send the fixing patch at mailing?
Oops..
Grant, Thanks for pointing out this.I will prepare the fix and send soon.
>
> Best Regards,
> Jaehoon Chung
>
> On 10/19/2013 05:13 AM, Grant Grundler wrote:
>> Chris, Yuvaraj, Alim, Jaehoon,
>>
>> This patch is wrong:
>> https://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?h=mmc-next&id=e6c784eded7b39caeaf2e9206336fa1daeccfd09
>>
>> sdr_timing needs to come from the of_property "samsung,dw-mshc-sdr-timing".
>> Assignment of priv->sdr_timing needs to move back where it was before.
>>
>> Can one of you guys "just fix it" or do you need a patch from me (or Sonny)?
>>
>> (This came up during my review of eMMC patches that sonny is
>> backporting to ChromeOS-3.8 kernel and I'm not done yet - have a ton
>> more to do here.)
>>
>> thanks,
>> grant
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-22 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-18 20:13 dw_mmc: priv->sdr_timing set wrong Grant Grundler
2013-10-22 6:45 ` Jaehoon Chung
2013-10-22 8:32 ` Yuvaraj Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.