Re: [PATCHv5] watchdog: dw: Enable OF support for DW watchdog timer

[Dinh Nguyen <dinh.linux@gmail.com>]

Hi Mark,

On 10/22/13 10:02 AM, Mark Rutland wrote:
> On Tue, Oct 22, 2013 at 03:38:47PM +0100, dinguyen@altera.com wrote:
>> From: Dinh Nguyen <dinguyen@altera.com>
>>
>> Add device tree support to the DW watchdog timer.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>> Acked-by: Jamie Iles <jamie@jamieiles.com>
>> Reviewed-by: Pavel Machek <pavel@denx.de>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Jamie Iles <jamie@jamieiles.com>
>> Cc: Viresh Kumar <viresh.linux@gmail.com>
>> Cc: Wim Van Sebroeck <wim@iguana.be>
>> Cc: Pavel Machek <pavel@denx.de>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Pawel Moll <pawel.moll@arm.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Stephen Warren <swarren@wwwdotorg.org>
>> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-watchdog@vger.kernel.org
>> ---
>> v5:
>> - Add documentation for clocks property
>> v4:
>> - Add interrupts as an optional property, use "should contain".
>> v3:
>> - Clean up documentation
>> v2:
>> - Use of_match_ptr() for of_match_table
>> ---
>>   .../devicetree/bindings/watchdog/dw_wdt.txt        |   20 ++++++++++++++++++++
>>   drivers/watchdog/dw_wdt.c                          |    8 ++++++++
>>   2 files changed, 28 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/watchdog/dw_wdt.txt
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
>> new file mode 100644
>> index 0000000..3af5c13
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
>> @@ -0,0 +1,20 @@
>> +Synopsys Designware Watchdog Timer
>> +
>> +Required Properties:
>> +
>> +- compatible	: Should contain "snps,dw-wdt"
>> +- reg		: Base address and size of the watchdog timer register.
> s/register/registers/ ?
>
>> +- clocks	: phandle to the clock that drives the watchdog timer.
> Nit: clocks aren't necessarily described by just a phandle.
>
> How about:
>
> - clocks: phandle + clock-specifier for the clock that drives the watchdog
>            timer.
>
> Otherwise, given previous comments this looks fine to me.
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
Fixed with above and added your Ack. So now the question is can take 
this through the
arm-soc tree or through Wim Van Sebroeck's drivers/watchdog tree?

Thanks,
Dinh
>
> Thanks,
> Mark.