All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Ben Hutchings <bhutchings@solarflare.com>,
	netdev@vger.kernel.org, Marek Lindner <lindner_marek@yahoo.de>,
	davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: export compatibility version via debugfs
Date: Mon, 19 Nov 2012 20:29:07 +0100	[thread overview]
Message-ID: <5268262.CIrZ93ERtB@bentobox> (raw)
In-Reply-To: <1353351150.4156.4.camel@bwh-desktop.uk.solarflarecom.com>

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Monday 19 November 2012 18:52:30 Ben Hutchings wrote:
> On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
> > Different versions of the batman-adv module may use the same compatibility
> > version, but this is not understandable at runtime (the only way is to
> > parse the kernel log and fetch the batman-adv advertisement message on
> > loading). The user may want to know whether two nodes using different
> > versions can communicate or not. For this purpose the module has to
> > export this value through debugfs.
> [...]
> 
> I do hope that you're not planning to use unstable debugfs interfaces
> indefinitely.

Why are you refering to the adding of an file as "incompatible" debugfs 
interface? I would call it additional information. And the rest of the commit 
message is talking about *possible* protocol incompatibilies of the network 
protocol (which caused this uncontrolled erruption of anger in a network 
maintainer).

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Ben Hutchings <bhutchings@solarflare.com>,
	Antonio Quartulli <ordex@autistici.org>,
	netdev@vger.kernel.org, Marek Lindner <lindner_marek@yahoo.de>,
	davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: export compatibility version via debugfs
Date: Mon, 19 Nov 2012 20:29:07 +0100	[thread overview]
Message-ID: <5268262.CIrZ93ERtB@bentobox> (raw)
In-Reply-To: <1353351150.4156.4.camel@bwh-desktop.uk.solarflarecom.com>

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Monday 19 November 2012 18:52:30 Ben Hutchings wrote:
> On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
> > Different versions of the batman-adv module may use the same compatibility
> > version, but this is not understandable at runtime (the only way is to
> > parse the kernel log and fetch the batman-adv advertisement message on
> > loading). The user may want to know whether two nodes using different
> > versions can communicate or not. For this purpose the module has to
> > export this value through debugfs.
> [...]
> 
> I do hope that you're not planning to use unstable debugfs interfaces
> indefinitely.

Why are you refering to the adding of an file as "incompatible" debugfs 
interface? I would call it additional information. And the rest of the commit 
message is talking about *possible* protocol incompatibilies of the network 
protocol (which caused this uncontrolled erruption of anger in a network 
maintainer).

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-11-19 19:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19  8:24 [B.A.T.M.A.N.] pull request: batman-adv 2012-11-19 Antonio Quartulli
2012-11-19  8:24 ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Mark best gateway in transtable_global debugfs Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: fix bla compare function Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: support array of debugfs general attributes Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: export compatibility version via debugfs Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19 18:52   ` [B.A.T.M.A.N.] " Ben Hutchings
2012-11-19 18:52     ` Ben Hutchings
2012-11-19 19:10     ` [B.A.T.M.A.N.] " David Miller
2012-11-19 19:10       ` David Miller
2012-11-19 19:29     ` Sven Eckelmann [this message]
2012-11-19 19:29       ` [B.A.T.M.A.N.] " Sven Eckelmann
2012-11-19 19:40       ` Ben Hutchings
2012-11-19 19:40         ` Ben Hutchings
2012-11-19 20:25         ` [B.A.T.M.A.N.] " Sven Eckelmann
2012-11-19 20:25           ` Sven Eckelmann
2012-11-19 19:47       ` David Miller
2012-11-19 19:47         ` David Miller
2012-11-19 21:09         ` [B.A.T.M.A.N.] " Antonio Quartulli
2012-11-19 21:09           ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 05/10] batman-adv: Add wrapper to look up neighbor and send skb Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 06/10] batman-adv: sysfs documentation should keep alphabetical order Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 07/10] batman-adv: Add function to calculate crc32c for the skb payload Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 08/10] batman-adv: Fix broadcast duplist for fragmentation Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 09/10] batman-adv: Start new development cycle Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli
2012-11-19  8:24 ` [B.A.T.M.A.N.] [PATCH 10/10] batman-adv: Use packing of 2 for all headers before an ethernet header Antonio Quartulli
2012-11-19  8:24   ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5268262.CIrZ93ERtB@bentobox \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=lindner_marek@yahoo.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.