From: "Pekka Pietikäinen" <pp@ee.oulu.fi>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Pablo Neira Ayuso <pablo@netfilter.org>
Cc: edumazet@google.com, netfilter-devel@vger.kernel.org
Subject: Re: netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag causes behavioural change in userspace?
Date: Thu, 24 Oct 2013 14:21:53 +0300 [thread overview]
Message-ID: <526902D1.50803@ee.oulu.fi> (raw)
In-Reply-To: <1382609706.7572.48.camel@edumazet-glaptop.roam.corp.google.com>
On 24/10/13 13:15, Eric Dumazet wrote:
> On Thu, 2013-10-24 at 11:52 +0200, Pablo Neira Ayuso wrote:
>> Hi Pekka,
>>
>> On Tue, Oct 22, 2013 at 04:33:48PM +0300, Pekka Pietikäinen wrote:
>>> After a kernel update to 3.11 (feat. commit
>>> 681f130f39e10087475383e6771b9366e26bab0c) my "generate fake tcp
>>> connections from random ip addresses" app broke.
>> Did you give a try to revert it and things were working back fine? I
>> think the root cause for this behaviour change is not in that patch.
> Yes, given that the option is off by default, I do not really understand
> the issue.
>
> Its true that the option is currently a bit flawed, but my refactoring
> of TCP listener should solve the problem soon. I do not feel necessary
> to 'fix' xt_socket --nowildcard right now.
>
Okie, did some poking, Going to before "use IP early demux" seems to
have found the real cause:
Old:
[ 1700.684685] sk->sk_state: 2
[ 1700.684688] wildcard: 0 transparent: 1, sk != skb->sk 1
[ 1700.684691] proto 6 192.168.122.93:22 -> 5.5.5.5:45856 (orig
5.5.5.5:45856) sock ffff8803fb7b1500
[ 1700.685583] sk->sk_state: 4
[ 1700.685585] wildcard: 0 transparent: 1, sk != skb->sk 1
[ 1700.685587] proto 6 192.168.122.93:22 -> 5.5.5.5:45856 (orig
5.5.5.5:45856) sock ffff8803fb7b1500
[ 1700.688443] sk->sk_state: 6
[ 1700.688445] wildcard: 0 transparent: 1, sk != skb->sk 1
New:
[ 1613.960054] sk->sk_state: 7
[ 1613.960057] wildcard: 1 transparent: 1, sk != skb->sk 0
[ 1613.960060] proto 6 192.168.122.93:22 -> 5.5.5.5:43540 (orig
5.5.5.5:43540) sock (null)
[ 1615.511751] sk->sk_state: 7
[ 1615.511754] wildcard: 1 transparent: 1, sk != skb->sk 0
[ 1615.511756] proto 6 192.168.122.93:22 -> 5.5.5.5:43540 (orig
5.5.5.5:43540) sock (null)
[ 1615.963020] sk->sk_state: 7
[ 1615.963022] wildcard: 1 transparent: 1, sk != skb->sk 0
[ 1615.963024] proto 6 192.168.122.93:22 -> 5.5.5.5:34950 (orig
5.5.5.5:34950) sock (null)
[ 1615.963036] sk->sk_state: 7
[ 1615.963037] wildcard: 1 transparent: 1, sk != skb->sk 0
[ 1615.963038] proto 6 192.168.122.93:22 -> 5.5.5.5:43540 (orig
5.5.5.5:43540) sock (null)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-24 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 13:33 netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag causes behavioural change in userspace? Pekka Pietikäinen
2013-10-24 8:28 ` Jari Turkia
2013-10-24 9:52 ` Pablo Neira Ayuso
2013-10-24 10:15 ` Eric Dumazet
2013-10-24 11:21 ` Pekka Pietikäinen [this message]
2013-10-24 12:05 ` Eric Dumazet
2013-10-24 12:27 ` Pekka Pietikäinen
2013-10-24 12:51 ` Florian Westphal
[not found] ` <52691D4F.4080903@ee.oulu.fi>
[not found] ` <20131024132936.GC993@breakpoint.cc>
[not found] ` <52695011.2060902@ee.oulu.fi>
2013-10-24 19:14 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526902D1.50803@ee.oulu.fi \
--to=pp@ee.oulu.fi \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.