From: "Pekka Pietikäinen" <pp@ee.oulu.fi>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
edumazet@google.com, netfilter-devel@vger.kernel.org
Subject: Re: netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag causes behavioural change in userspace?
Date: Thu, 24 Oct 2013 15:27:06 +0300 [thread overview]
Message-ID: <5269121A.3040104@ee.oulu.fi> (raw)
In-Reply-To: <1382616307.7572.56.camel@edumazet-glaptop.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On 24/10/13 15:05, Eric Dumazet wrote:
> sk_state 7 means TCP_CLOSE
>
> I do not see how a TCP_CLOSE socket can be matched...
>
Yep, TCP_CLOSE can't be right, sk_state isn't correct with early demux
perhaps?
Finding
https://android.googlesource.com/kernel/common/+/experimental/android-3.8%5E!/
I managed to get the old behaviour with the attached patch, but I'm
having a hard time following what's really happening.
[-- Attachment #2: xt_socket.diff --]
[-- Type: text/plain, Size: 442 bytes --]
--- /usr/src/debug/kernel-3.11.fc19/linux-3.11.6-200.fc19.x86_64/net/netfilter/xt_socket.c 2013-09-02 23:46:10.000000000 +0300
+++ xt_socket.c 2013-10-24 15:07:59.592607433 +0300
@@ -115,6 +115,8 @@
struct nf_conn const *ct;
enum ip_conntrack_info ctinfo;
#endif
+ if (sk && sk->sk_state == TCP_CLOSE)
+ sk = NULL;
if (iph->protocol == IPPROTO_UDP || iph->protocol == IPPROTO_TCP) {
hp = skb_header_pointer(skb, ip_hdrlen(skb),
next prev parent reply other threads:[~2013-10-24 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 13:33 netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag causes behavioural change in userspace? Pekka Pietikäinen
2013-10-24 8:28 ` Jari Turkia
2013-10-24 9:52 ` Pablo Neira Ayuso
2013-10-24 10:15 ` Eric Dumazet
2013-10-24 11:21 ` Pekka Pietikäinen
2013-10-24 12:05 ` Eric Dumazet
2013-10-24 12:27 ` Pekka Pietikäinen [this message]
2013-10-24 12:51 ` Florian Westphal
[not found] ` <52691D4F.4080903@ee.oulu.fi>
[not found] ` <20131024132936.GC993@breakpoint.cc>
[not found] ` <52695011.2060902@ee.oulu.fi>
2013-10-24 19:14 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5269121A.3040104@ee.oulu.fi \
--to=pp@ee.oulu.fi \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.