[PATCH] mesa appends: remove PROVIDES

[PATCH] mesa appends: remove PROVIDES

[Andreas Müller]

These came in when mesa was reworked. Nowadays they are useless and what
they try to do achieve is wrong: provider for virtual/libgsl should be
mesa-gl. The appends were left in to avoid backward revision trouble in
package feeds.

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 recipes-graphics/mesa/mesa-omap3-common.inc | 7 -------
 recipes-graphics/mesa/mesa_9.1.6.bbappend   | 3 ++-
 recipes-graphics/mesa/mesa_git.bbappend     | 3 ++-
 3 files changed, 4 insertions(+), 9 deletions(-)
 delete mode 100644 recipes-graphics/mesa/mesa-omap3-common.inc

diff --git a/recipes-graphics/mesa/mesa-omap3-common.inc b/recipes-graphics/mesa/mesa-omap3-common.inc
deleted file mode 100644
index 0340770..0000000
--- a/recipes-graphics/mesa/mesa-omap3-common.inc
+++ /dev/null
@@ -1,7 +0,0 @@
-PRINC := "${@int(PRINC) + 1}"
-
-# avoid providing conflicts for libgles-omap3 compatibles
-PROVIDES_omap3 = "virtual/libgl"
-PROVIDES_ti814x = "virtual/libgl"
-PROVIDES_ti816x = "virtual/libgl"
-PROVIDES_ti33x = "virtual/libgl"
diff --git a/recipes-graphics/mesa/mesa_9.1.6.bbappend b/recipes-graphics/mesa/mesa_9.1.6.bbappend
index 164ec1b..8445337 100644
--- a/recipes-graphics/mesa/mesa_9.1.6.bbappend
+++ b/recipes-graphics/mesa/mesa_9.1.6.bbappend
@@ -1 +1,2 @@
-require mesa-omap3-common.inc
+PRINC := "${@int(PRINC) + 1}"
+
diff --git a/recipes-graphics/mesa/mesa_git.bbappend b/recipes-graphics/mesa/mesa_git.bbappend
index 164ec1b..8445337 100644
--- a/recipes-graphics/mesa/mesa_git.bbappend
+++ b/recipes-graphics/mesa/mesa_git.bbappend
@@ -1 +1,2 @@
-require mesa-omap3-common.inc
+PRINC := "${@int(PRINC) + 1}"
+
-- 
1.8.3.1

Re: [PATCH] mesa appends: remove PROVIDES

[Gary Thomas]

On 2013-10-24 03:29, Andreas Müller wrote:
> These came in when mesa was reworked. Nowadays they are useless and what
> they try to do achieve is wrong: provider for virtual/libgsl should be
> mesa-gl. The appends were left in to avoid backward revision trouble in
> package feeds.

If this is the correct solution, I think these .bbappend files should be
removed completely.  They don't change anything and keeping them just to
retain the PRINC is useless because as is one cannot even build a system
which uses virtual/mesa, e.g. one using the X11 server.  In addition, the
main mesa recipe is about to be updated so they'll need changing again very
soon.

>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>   recipes-graphics/mesa/mesa-omap3-common.inc | 7 -------
>   recipes-graphics/mesa/mesa_9.1.6.bbappend   | 3 ++-
>   recipes-graphics/mesa/mesa_git.bbappend     | 3 ++-
>   3 files changed, 4 insertions(+), 9 deletions(-)
>   delete mode 100644 recipes-graphics/mesa/mesa-omap3-common.inc
>
> diff --git a/recipes-graphics/mesa/mesa-omap3-common.inc b/recipes-graphics/mesa/mesa-omap3-common.inc
> deleted file mode 100644
> index 0340770..0000000
> --- a/recipes-graphics/mesa/mesa-omap3-common.inc
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -PRINC := "${@int(PRINC) + 1}"
> -
> -# avoid providing conflicts for libgles-omap3 compatibles
> -PROVIDES_omap3 = "virtual/libgl"
> -PROVIDES_ti814x = "virtual/libgl"
> -PROVIDES_ti816x = "virtual/libgl"
> -PROVIDES_ti33x = "virtual/libgl"
> diff --git a/recipes-graphics/mesa/mesa_9.1.6.bbappend b/recipes-graphics/mesa/mesa_9.1.6.bbappend
> index 164ec1b..8445337 100644
> --- a/recipes-graphics/mesa/mesa_9.1.6.bbappend
> +++ b/recipes-graphics/mesa/mesa_9.1.6.bbappend
> @@ -1 +1,2 @@
> -require mesa-omap3-common.inc
> +PRINC := "${@int(PRINC) + 1}"
> +
> diff --git a/recipes-graphics/mesa/mesa_git.bbappend b/recipes-graphics/mesa/mesa_git.bbappend
> index 164ec1b..8445337 100644
> --- a/recipes-graphics/mesa/mesa_git.bbappend
> +++ b/recipes-graphics/mesa/mesa_git.bbappend
> @@ -1 +1,2 @@
> -require mesa-omap3-common.inc
> +PRINC := "${@int(PRINC) + 1}"
> +
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH] mesa appends: remove PROVIDES

[Andreas Müller]

On Thu, Oct 24, 2013 at 1:23 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> On 2013-10-24 03:29, Andreas Müller wrote:
>>
>> These came in when mesa was reworked. Nowadays they are useless and what
>> they try to do achieve is wrong: provider for virtual/libgsl should be
>> mesa-gl. The appends were left in to avoid backward revision trouble in
>> package feeds.
>
>
> If this is the correct solution, I think these .bbappend files should be
> removed completely.  They don't change anything and keeping them just to
> retain the PRINC is useless because as is one cannot even build a system
> which uses virtual/mesa, e.g. one using the X11 server.  In addition, the
> main mesa recipe is about to be updated so they'll need changing again very
> soon.
>
So let's kick them out as soon as mesa is updated

Andreas

Re: [PATCH] mesa appends: remove PROVIDES

[Dmytriyenko, Denys]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Thanks, I'll have to look at it once I'm back from ELCE...


Denys


-----Original Message-----
From: Andreas Müller [schnitzeltony@googlemail.com]
Received: Thursday, 24 Oct 2013, 12:49
To: Gary Thomas [gary@mlbassoc.com]
CC: meta-ti@yoctoproject.org [meta-ti@yoctoproject.org]
Subject: Re: [meta-ti] [PATCH] mesa appends: remove PROVIDES

On Thu, Oct 24, 2013 at 1:23 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> On 2013-10-24 03:29, Andreas Müller wrote:
>>
>> These came in when mesa was reworked. Nowadays they are useless and what
>> they try to do achieve is wrong: provider for virtual/libgsl should be
>> mesa-gl. The appends were left in to avoid backward revision trouble in
>> package feeds.
>
>
> If this is the correct solution, I think these .bbappend files should be
> removed completely.  They don't change anything and keeping them just to
> retain the PRINC is useless because as is one cannot even build a system
> which uses virtual/mesa, e.g. one using the X11 server.  In addition, the
> main mesa recipe is about to be updated so they'll need changing again very
> soon.
>
So let's kick them out as soon as mesa is updated

Andreas
_______________________________________________
meta-ti mailing list
meta-ti@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-ti

[-- Attachment #2: Type: text/html, Size: 2299 bytes --]

Re: [PATCH] mesa appends: remove PROVIDES

[Khem Raj]

ping. I am also waiting on this patch or similar getting in into meta-ti

On Thu, Oct 24, 2013 at 5:14 AM, Dmytriyenko, Denys <denys@ti.com> wrote:
> Thanks, I'll have to look at it once I'm back from ELCE...
>
>
> Denys
>
>
>
> -----Original Message-----
> From: Andreas Müller [schnitzeltony@googlemail.com]
> Received: Thursday, 24 Oct 2013, 12:49
> To: Gary Thomas [gary@mlbassoc.com]
> CC: meta-ti@yoctoproject.org [meta-ti@yoctoproject.org]
> Subject: Re: [meta-ti] [PATCH] mesa appends: remove PROVIDES
>
> On Thu, Oct 24, 2013 at 1:23 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> On 2013-10-24 03:29, Andreas Müller wrote:
>>>
>>> These came in when mesa was reworked. Nowadays they are useless and what
>>> they try to do achieve is wrong: provider for virtual/libgsl should be
>>> mesa-gl. The appends were left in to avoid backward revision trouble in
>>> package feeds.
>>
>>
>> If this is the correct solution, I think these .bbappend files should be
>> removed completely.  They don't change anything and keeping them just to
>> retain the PRINC is useless because as is one cannot even build a system
>> which uses virtual/mesa, e.g. one using the X11 server.  In addition, the
>> main mesa recipe is about to be updated so they'll need changing again
>> very
>> soon.
>>
> So let's kick them out as soon as mesa is updated
>
> Andreas
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
>
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
>