[PATCH v3] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()

[PATCH v3] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()

[Armandas Kvietkus via B4 Relay]

From: Armandas Kvietkus <armandas.kvietkus@proton.me>

When firmware does not support the fan curve WMI method,
asus_wmi_evaluate_method_buf() returns -ENODEV. Callers treat this
as non-fatal, but the pr_warn() here still fires, producing
spurious boot noise on unsupported hardware. Downgrade the message
to pr_debug().

---
Changes in v3:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v2: https://patch.msgid.link/20260825-fan-curve-v2-1-2ee1ffd2a1a3@proton.me
---
Changes in v2:
- Downgrade the message to pr_debug() as suggested by Ilpo Järvinen.
- Link to v1: https://lore.kernel.org/r/20260503174752.26288-1-armundunelis@gmail.com
---
 drivers/platform/x86/asus-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index e835779b6..527289b7d 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -3610,7 +3610,7 @@ static int fan_curve_get_factory_default(struct asus_wmi *asus, u32 fan_dev)
 	err = asus_wmi_evaluate_method_buf(asus->dsts_id, fan_dev, mode, buf,
 					   FAN_CURVE_BUF_LEN);
 	if (err) {
-		pr_warn("%s (0x%08x) failed: %d\n", __func__, fan_dev, err);
+		pr_debug("%s (0x%08x) failed: %d\n", __func__, fan_dev, err);
 		return err;
 	}
 

---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260824-fan-curve-enODEV

Best regards,
--  
Armandas Kvietkus <armandas.kvietkus@proton.me>

[PATCH v3] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()

[Armandas Kvietkus]

When firmware does not support the fan curve WMI method,
asus_wmi_evaluate_method_buf() returns -ENODEV. Callers treat this
as non-fatal, but the pr_warn() here still fires, producing
spurious boot noise on unsupported hardware. Downgrade the message
to pr_debug().

---
Changes in v3:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v2: https://patch.msgid.link/20260825-fan-curve-v2-1-2ee1ffd2a1a3@proton.me
---
Changes in v2:
- Downgrade the message to pr_debug() as suggested by Ilpo Järvinen.
- Link to v1: https://lore.kernel.org/r/20260503174752.26288-1-armundunelis@gmail.com
---
 drivers/platform/x86/asus-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index e835779b6..527289b7d 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -3610,7 +3610,7 @@ static int fan_curve_get_factory_default(struct asus_wmi *asus, u32 fan_dev)
 	err = asus_wmi_evaluate_method_buf(asus->dsts_id, fan_dev, mode, buf,
 					   FAN_CURVE_BUF_LEN);
 	if (err) {
-		pr_warn("%s (0x%08x) failed: %d\n", __func__, fan_dev, err);
+		pr_debug("%s (0x%08x) failed: %d\n", __func__, fan_dev, err);
 		return err;
 	}
 

---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260824-fan-curve-enODEV

Best regards,
--  
Armandas Kvietkus <armandas.kvietkus@proton.me>

Re: [PATCH v3] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()

[Ilpo Järvinen]

On Tue, 25 Aug 2026 00:47:07 +0200, Armandas Kvietkus wrote:

> When firmware does not support the fan curve WMI method,
> asus_wmi_evaluate_method_buf() returns -ENODEV. Callers treat this
> as non-fatal, but the pr_warn() here still fires, producing
> spurious boot noise on unsupported hardware. Downgrade the message
> to pr_debug().
> 
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()
      commit: 9af7fddef448d649fa1332d86a14465a1d1fafe3

--
 i.

Re: [PATCH v3] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

On Fri, 18 Sep 2026, Ilpo Järvinen wrote:

> On Tue, 25 Aug 2026 00:47:07 +0200, Armandas Kvietkus wrote:
> 
> > When firmware does not support the fan curve WMI method,
> > asus_wmi_evaluate_method_buf() returns -ENODEV. Callers treat this
> > as non-fatal, but the pr_warn() here still fires, producing
> > spurious boot noise on unsupported hardware. Downgrade the message
> > to pr_debug().
> > 
> > 
> > [...]
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-next branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> local branch there, which might take a while.
> 
> FYI [if applicable to your patch], as per Linus' policy change, also
> fixes are mostly routed through for-next unless the fix is for a
> commit introduced in the most recent cycle or is clearly a regression
> fix.
> 
> The list of commits applied:
> [1/1] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()
>       commit: 9af7fddef448d649fa1332d86a14465a1d1fafe3

I had to dropped this patch because it's lacking a proper Signed-off-by 
tag.

Please see Documentation/process/submitting-patches.rst for more 
information on what is required and send a new version with the problem 
corrected.


-- 
 i.