From: Daniel Borkmann <dborkman@redhat.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH ipvs 1/2] net: ipvs: sctp: add missing verdict assignments in sctp_conn_schedule
Date: Fri, 25 Oct 2013 10:03:22 +0000 [thread overview]
Message-ID: <526A41EA.1030403@redhat.com> (raw)
In-Reply-To: <1af1d5e1aae9df91683625f0cb120b329e8d2f10.1382689350.git.dborkman@redhat.com>
On 10/25/2013 11:55 AM, Simon Horman wrote:
> On Fri, Oct 25, 2013 at 11:39:02AM +0200, Jesper Dangaard Brouer wrote:
>> On Fri, 25 Oct 2013 11:05:04 +0200
>> Daniel Borkmann <dborkman@redhat.com> wrote:
>>
>>> If skb_header_pointer() fails, we need to assign a verdict, that is
>>> NF_DROP in this case, otherwise, we would leave the verdict from
>>> conn_schedule() uninitialized when returning.
>>>
>>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>>> ---
>>
>> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
>>
>> It looks like a good ide, and resembles how we handle these situations
>> else were in the IPVS code (e.g. for TCP and UDP).
>
> Likeiwse.
>
> I am wondering if this resolves a but and if so how severe it is.
Probably with malformed SCTP INIT packets, but haven't tried so far.
Just found it during code review.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
lvs-devel@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH ipvs 1/2] net: ipvs: sctp: add missing verdict assignments in sctp_conn_schedule
Date: Fri, 25 Oct 2013 12:03:22 +0200 [thread overview]
Message-ID: <526A41EA.1030403@redhat.com> (raw)
In-Reply-To: <20131025095534.GI17127@verge.net.au>
On 10/25/2013 11:55 AM, Simon Horman wrote:
> On Fri, Oct 25, 2013 at 11:39:02AM +0200, Jesper Dangaard Brouer wrote:
>> On Fri, 25 Oct 2013 11:05:04 +0200
>> Daniel Borkmann <dborkman@redhat.com> wrote:
>>
>>> If skb_header_pointer() fails, we need to assign a verdict, that is
>>> NF_DROP in this case, otherwise, we would leave the verdict from
>>> conn_schedule() uninitialized when returning.
>>>
>>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>>> ---
>>
>> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
>>
>> It looks like a good ide, and resembles how we handle these situations
>> else were in the IPVS code (e.g. for TCP and UDP).
>
> Likeiwse.
>
> I am wondering if this resolves a but and if so how severe it is.
Probably with malformed SCTP INIT packets, but haven't tried so far.
Just found it during code review.
next prev parent reply other threads:[~2013-10-25 10:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 9:05 [PATCH ipvs 1/2] net: ipvs: sctp: add missing verdict assignments in sctp_conn_schedule Daniel Borkmann
2013-10-25 9:05 ` Daniel Borkmann
2013-10-25 9:39 ` Jesper Dangaard Brouer
2013-10-25 9:39 ` Jesper Dangaard Brouer
2013-10-25 9:55 ` Simon Horman
2013-10-25 9:55 ` Simon Horman
2013-10-25 10:03 ` Daniel Borkmann [this message]
2013-10-25 10:03 ` Daniel Borkmann
2013-10-25 12:59 ` Neil Horman
2013-10-25 12:59 ` Neil Horman
2013-10-25 21:05 ` Julian Anastasov
2013-10-25 21:05 ` Julian Anastasov
-- strict thread matches above, loose matches on Subject: below --
2013-10-25 9:05 [PATCH ipvs 2/2] net: ipvs: sctp: do not recalc sctp checksum when not needed Daniel Borkmann
2013-10-25 9:05 ` Daniel Borkmann
2013-10-25 9:48 ` Jesper Dangaard Brouer
2013-10-25 9:48 ` Jesper Dangaard Brouer
2013-10-25 13:01 ` Neil Horman
2013-10-25 13:01 ` Neil Horman
2013-10-25 21:00 ` Julian Anastasov
2013-10-25 21:00 ` Julian Anastasov
2013-10-26 18:55 ` Daniel Borkmann
2013-10-26 18:55 ` Daniel Borkmann
2013-10-28 1:39 ` Simon Horman
2013-10-28 1:39 ` Simon Horman
2013-10-28 8:11 ` Daniel Borkmann
2013-10-28 8:11 ` Daniel Borkmann
2013-10-28 8:11 ` Julian Anastasov
2013-10-28 8:11 ` Julian Anastasov
2013-10-28 8:50 ` Simon Horman
2013-10-28 8:50 ` Simon Horman
2013-10-28 9:00 ` Julian Anastasov
2013-10-28 9:00 ` Julian Anastasov
2013-10-28 9:38 ` Simon Horman
2013-10-28 9:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A41EA.1030403@redhat.com \
--to=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.