Re: [Qemu-devel] Bug#727756: qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)

[Michael Tokarev <mjt@tls.msk.ru>]

26.10.2013 13:07, Michael Büsch wrote:
> Package: qemu
> Version: 1.6.0+dfsg-2
> Severity: normal
> Tags: patch
>
> The smb.conf automatically generated by qemu's -smb option fails on current samba,
> because smbd rejects the security=share option with the following warning:
>
>>    WARNING: Ignoring invalid value 'share' for parameter 'security'
>
> Which makes it fall back to security=user without guest login.
> This results in being unable to login to the samba server from the guest OS.
>
> The attached patch fixes this by selecting 'user' explicitly and mapping
> unknown users to guest logins.


Index: qemu-1.6.0+dfsg/net/slirp.c
===================================================================
--- qemu-1.6.0+dfsg.orig/net/slirp.c
+++ qemu-1.6.0+dfsg/net/slirp.c
@@ -529,7 +529,8 @@ static int slirp_smb(SlirpState* s, cons
              "state directory=%s\n"
              "log file=%s/log.smbd\n"
              "smb passwd file=%s/smbpasswd\n"
-            "security = share\n"
+            "security = user\n"
+            "map to guest = Bad User\n"
              "[qemu]\n"
              "path=%s\n"
              "read only=no\n"

Thank you for the report and the patch Michael.  Are you sure the result
is equivalent?  I mean, it *looks* like okay, because [qemu] share definition -
which looks like this:

             [qemu]
             path=%s
             read only=no
             guest ok=yes
             force user=%s

explicitly says that guest is okay, and forces user to the
right one.  And it should work the same with other versions
of samba too.

But samba collected so many semi-conflicting options with
years, so I'm not sure anymore.

Also, which users are "bad" -- will it be possible for our
user to "clash" with some built-in/known user?

Cc'ing qemu-devel@ because this needs to be resolved
upstream too.

Thank you again,

/mjt