From: Daniel Borkmann <dborkman@redhat.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2 ipvs-next] net: ipvs: sctp: do not recalc sctp csum when ports didn't change
Date: Mon, 28 Oct 2013 09:47:25 +0000 [thread overview]
Message-ID: <526E32AD.8030203@redhat.com> (raw)
In-Reply-To: <1382951695-7759-1-git-send-email-dborkman@redhat.com>
On 10/28/2013 10:44 AM, Julian Anastasov wrote:
[...]
> Sorry, just now noticed the errors from
> scripts/checkpatch.pl:
>
> ERROR: do not use assignment in if condition
> #78: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:103:
> + if (!(ret = ip_vs_app_pkt_out(cp, skb)))
>
> ERROR: do not use assignment in if condition
> #120: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:149:
> + if (!(ret = ip_vs_app_pkt_in(cp, skb)))
>
> total: 2 errors, 0 warnings, 81 lines checked
>
> I know that you copied the TCP logic that was
> added by me but now we should split the complex conditions
> at both places:
>
> ret = ...
> if (!ret)
> return 0;
>
> Otherwise patch looks good and I'll ack v3 with
> the above changes.
Ok, sure, I'll update with the cosmetic change.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: horms@verge.net.au, lvs-devel@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2 ipvs-next] net: ipvs: sctp: do not recalc sctp csum when ports didn't change
Date: Mon, 28 Oct 2013 10:47:25 +0100 [thread overview]
Message-ID: <526E32AD.8030203@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.03.1310281136300.1490@ssi.bg>
On 10/28/2013 10:44 AM, Julian Anastasov wrote:
[...]
> Sorry, just now noticed the errors from
> scripts/checkpatch.pl:
>
> ERROR: do not use assignment in if condition
> #78: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:103:
> + if (!(ret = ip_vs_app_pkt_out(cp, skb)))
>
> ERROR: do not use assignment in if condition
> #120: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:149:
> + if (!(ret = ip_vs_app_pkt_in(cp, skb)))
>
> total: 2 errors, 0 warnings, 81 lines checked
>
> I know that you copied the TCP logic that was
> added by me but now we should split the complex conditions
> at both places:
>
> ret = ...
> if (!ret)
> return 0;
>
> Otherwise patch looks good and I'll ack v3 with
> the above changes.
Ok, sure, I'll update with the cosmetic change.
next prev parent reply other threads:[~2013-10-28 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 9:14 [PATCH v2 ipvs-next] net: ipvs: sctp: do not recalc sctp csum when ports didn't change Daniel Borkmann
2013-10-28 9:14 ` Daniel Borkmann
2013-10-28 9:44 ` Julian Anastasov
2013-10-28 9:44 ` Julian Anastasov
2013-10-28 9:47 ` Daniel Borkmann [this message]
2013-10-28 9:47 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E32AD.8030203@redhat.com \
--to=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.