* Sven Vermeulen patch to fix sepolgen test code
@ 2013-10-25 19:45 Daniel J Walsh
2013-10-25 20:12 ` Stephen Smalley
0 siblings, 1 reply; 3+ messages in thread
From: Daniel J Walsh @ 2013-10-25 19:45 UTC (permalink / raw)
To: eparis; +Cc: selinux
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch looks good to me. acked.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlJqyjwACgkQrlYvE4MpobPOrACfXpHHSoNEDHytIY+7ium4lYFD
OYMAoL4Ssd2HQadUHpviHTxsK96av8Go
=GExO
-----END PGP SIGNATURE-----
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-Sven-Vermeulen-patch-to-fix-sepolgen-test-code.patch --]
[-- Type: text/x-patch; name="0002-Sven-Vermeulen-patch-to-fix-sepolgen-test-code.patch", Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Sven Vermeulen patch to fix sepolgen test code
2013-10-25 19:45 Sven Vermeulen patch to fix sepolgen test code Daniel J Walsh
@ 2013-10-25 20:12 ` Stephen Smalley
2013-10-28 13:43 ` Daniel J Walsh
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Smalley @ 2013-10-25 20:12 UTC (permalink / raw)
To: Daniel J Walsh; +Cc: eparis, selinux
On 10/25/2013 03:45 PM, Daniel J Walsh wrote:
>
> This patch looks good to me. acked.
This reverts the fix I just applied, and causes make test to fail in
sepolgen for me. Do you see a different result? Also, cc me.
Current selinux master:
cd selinux
git checkout master
git pull
cd sepolgen
make test
$ make test
make -C tests test
make[1]: Entering directory `/home/sds/selinux/sepolgen/tests'
python run-tests.py
...........................................
----------------------------------------------------------------------
Ran 43 tests in 0.811s
OK
make[1]: Leaving directory `/home/sds/selinux/sepolgen/tests'
With this patch:
make -C tests test
make[1]: Entering directory `/home/sds/selinux/sepolgen/tests'
python run-tests.py
............................F..............
======================================================================
FAIL: test_append (test_matching.TestMatchList)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/sds/selinux/sepolgen/tests/test_matching.py", line 54, in
test_append
self.assertEqual(len(ml), 2)
AssertionError: 1 != 2
----------------------------------------------------------------------
Ran 43 tests in 0.796s
FAILED (failures=1)
make[1]: *** [test] Error 1
make[1]: Leaving directory `/home/sds/selinux/sepolgen/tests'
make: *** [test] Error 2
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Sven Vermeulen patch to fix sepolgen test code
2013-10-25 20:12 ` Stephen Smalley
@ 2013-10-28 13:43 ` Daniel J Walsh
0 siblings, 0 replies; 3+ messages in thread
From: Daniel J Walsh @ 2013-10-28 13:43 UTC (permalink / raw)
To: Stephen Smalley; +Cc: eparis, selinux
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/25/2013 04:12 PM, Stephen Smalley wrote:
> On 10/25/2013 03:45 PM, Daniel J Walsh wrote:
>>
>> This patch looks good to me. acked.
>
> This reverts the fix I just applied, and causes make test to fail in
> sepolgen for me. Do you see a different result? Also, cc me.
>
> Current selinux master: cd selinux git checkout master git pull cd
> sepolgen make test $ make test make -C tests test make[1]: Entering
> directory `/home/sds/selinux/sepolgen/tests' python run-tests.py
> ..........................................
> ---------------------------------------------------------------------- Ran
> 43 tests in 0.811s
>
> OK make[1]: Leaving directory `/home/sds/selinux/sepolgen/tests'
>
> With this patch: make -C tests test make[1]: Entering directory
> `/home/sds/selinux/sepolgen/tests' python run-tests.py
> ...........................F..............
> ======================================================================
> FAIL: test_append (test_matching.TestMatchList)
> ----------------------------------------------------------------------
> Traceback (most recent call last): File
> "/home/sds/selinux/sepolgen/tests/test_matching.py", line 54, in
> test_append self.assertEqual(len(ml), 2) AssertionError: 1 != 2
>
> ---------------------------------------------------------------------- Ran
> 43 tests in 0.796s
>
> FAILED (failures=1) make[1]: *** [test] Error 1 make[1]: Leaving directory
> `/home/sds/selinux/sepolgen/tests' make: *** [test] Error 2
>
>
>
>
> -- This message was distributed to subscribers of the selinux mailing
> list. If you no longer wish to subscribe, send mail to
> majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes
> as the message.
>
>
I agree the value should be 1 not 2. Need to drop patch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlJuagEACgkQrlYvE4MpobPrcwCghA4N8gmCWO2B1lpFIpoZtTup
dRAAnRYzJTYM1bunKIz84G1U4bf1dcHU
=tFPq
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-28 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-25 19:45 Sven Vermeulen patch to fix sepolgen test code Daniel J Walsh
2013-10-25 20:12 ` Stephen Smalley
2013-10-28 13:43 ` Daniel J Walsh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.