From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: minchan@kernel.org, zhang.mingjun@linaro.org
Cc: m.szyprowski@samsung.com, akpm@linux-foundation.org,
mgorman@suse.de, haojian.zhuang@linaro.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, troy.zhangmingjun@linaro.org
Subject: Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page
Date: Tue, 29 Oct 2013 02:41:57 -0400 [thread overview]
Message-ID: <526F58B5.7020503@jp.fujitsu.com> (raw)
In-Reply-To: <20131029045430.GE17038@bbox>
> The concern is likely/unlikely usage is proper in this code peice.
> If we don't use memory isolation, the code path is used for only
> MIGRATE_RESERVE which is very rare allocation in normal workload.
>
> Even, in memory isolation environement, I'm not sure how many
> CMA/HOTPLUG is used compared to normal alloc/free.
> So, I think below is more proper?
>
> if (unlikely(migratetype >= MIGRATE_PCPTYPES)) {
> if (is_migrate_isolate(migratetype) || is_migrate_cma(migratetype))
>
> I know it's an another topic but I'd like to disucss it in this time because
> we will forget such trivial thing later, again.
I completely agree with this.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: minchan@kernel.org, zhang.mingjun@linaro.org
Cc: m.szyprowski@samsung.com, akpm@linux-foundation.org,
mgorman@suse.de, haojian.zhuang@linaro.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, troy.zhangmingjun@linaro.org
Subject: Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page
Date: Tue, 29 Oct 2013 02:41:57 -0400 [thread overview]
Message-ID: <526F58B5.7020503@jp.fujitsu.com> (raw)
In-Reply-To: <20131029045430.GE17038@bbox>
> The concern is likely/unlikely usage is proper in this code peice.
> If we don't use memory isolation, the code path is used for only
> MIGRATE_RESERVE which is very rare allocation in normal workload.
>
> Even, in memory isolation environement, I'm not sure how many
> CMA/HOTPLUG is used compared to normal alloc/free.
> So, I think below is more proper?
>
> if (unlikely(migratetype >= MIGRATE_PCPTYPES)) {
> if (is_migrate_isolate(migratetype) || is_migrate_cma(migratetype))
>
> I know it's an another topic but I'd like to disucss it in this time because
> we will forget such trivial thing later, again.
I completely agree with this.
next prev parent reply other threads:[~2013-10-29 6:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 11:42 [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page zhang.mingjun
2013-10-28 11:42 ` zhang.mingjun
2013-10-28 16:04 ` Laura Abbott
2013-10-28 16:04 ` Laura Abbott
2013-10-29 4:54 ` Minchan Kim
2013-10-29 4:54 ` Minchan Kim
2013-10-29 6:41 ` KOSAKI Motohiro [this message]
2013-10-29 6:41 ` KOSAKI Motohiro
2013-10-29 7:00 ` Zhang Mingjun
2013-10-29 7:25 ` Minchan Kim
2013-10-29 7:25 ` Minchan Kim
2013-10-29 11:17 ` Zhang Mingjun
2013-10-29 9:33 ` Mel Gorman
2013-10-29 9:33 ` Mel Gorman
2013-10-29 11:49 ` Zhang Mingjun
2013-10-29 12:27 ` Mel Gorman
2013-10-29 12:27 ` Mel Gorman
2013-10-29 15:02 ` Zhang Mingjun
2013-10-29 16:14 ` Laura Abbott
2013-10-29 16:14 ` Laura Abbott
2013-10-30 5:40 ` Minchan Kim
2013-10-30 5:40 ` Minchan Kim
2013-10-31 2:14 ` Laura Abbott
2013-10-31 2:14 ` Laura Abbott
2013-11-01 1:49 ` Minchan Kim
2013-11-01 1:49 ` Minchan Kim
2013-12-23 12:38 ` Wanpeng Li
2013-10-30 2:55 ` Minchan Kim
2013-10-30 2:55 ` Minchan Kim
2013-11-05 21:44 ` Andrew Morton
2013-11-05 21:44 ` Andrew Morton
2013-11-06 6:43 ` Minchan Kim
2013-11-06 6:43 ` Minchan Kim
2013-11-06 23:41 ` Andrew Morton
2013-11-06 23:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526F58B5.7020503@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=troy.zhangmingjun@linaro.org \
--cc=zhang.mingjun@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.