All of lore.kernel.org
 help / color / mirror / Atom feed
* Can't build any images
@ 2013-10-29 15:08 Gary Thomas
  2013-10-29 15:15 ` Paul Eggleton
  0 siblings, 1 reply; 3+ messages in thread
From: Gary Thomas @ 2013-10-29 15:08 UTC (permalink / raw)
  To: Yocto Project

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Since this commit:
   commit 8b42409dca729b7abbbdac04f533e161de86a3ef
   Author: Paul Eggleton <paul.eggleton@linux.intel.com>
   Date:   Fri Oct 18 15:19:58 2013 +0100

     scripts/oe-pkgdata-util: improve help text and command line parsing

     * Use optparse to parse command line
     * Make help text actually helpful by describing what each command does
     * Drop comment at the top listing the commands which is now superfluous

     (From OE-Core rev: feb317513fff638ad7abdba8ab34b8413f0ab055)

     Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

I get these errors for any image I try to create:
   | Traceback (most recent call last):
   |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 334, in <module>
   |     main()
   |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 319, in main
   |     glob(args[1:], parser.print_help)
   |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 143, in glob
   |     if debug:
   | NameError: global name 'debug' is not defined

The attached patch fixes the problem, but I'm not sure if it is 100% correct.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

[-- Attachment #2: oe.patch --]
[-- Type: text/x-patch, Size: 511 bytes --]

diff --git a/scripts/oe-pkgdata-util b/scripts/oe-pkgdata-util
index 80cacc5..14e81aa 100755
--- a/scripts/oe-pkgdata-util
+++ b/scripts/oe-pkgdata-util
@@ -283,8 +283,10 @@ def find_path(args, usage):
                                 if fnmatch.fnmatchcase(fullpth, targetpath):
                                     print("%s: %s" % (fn, fullpth))
 
+debug = False
 
 def main():
+    global debug
     parser = optparse.OptionParser(
         usage = '''%prog [options] <command> <arguments>
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Can't build any images
  2013-10-29 15:08 Can't build any images Gary Thomas
@ 2013-10-29 15:15 ` Paul Eggleton
  2013-10-29 15:32   ` Gary Thomas
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggleton @ 2013-10-29 15:15 UTC (permalink / raw)
  To: Gary Thomas; +Cc: yocto

On Tuesday 29 October 2013 09:08:01 Gary Thomas wrote:
> Since this commit:
>    commit 8b42409dca729b7abbbdac04f533e161de86a3ef
>    Author: Paul Eggleton <paul.eggleton@linux.intel.com>
>    Date:   Fri Oct 18 15:19:58 2013 +0100
> 
>      scripts/oe-pkgdata-util: improve help text and command line parsing
> 
>      * Use optparse to parse command line
>      * Make help text actually helpful by describing what each command does
>      * Drop comment at the top listing the commands which is now superfluous
> 
>      (From OE-Core rev: feb317513fff638ad7abdba8ab34b8413f0ab055)
> 
>      Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
>      Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> I get these errors for any image I try to create:
>    | Traceback (most recent call last):
>    |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 334, in
>    |   <module>   |   
>    |     main()
>    |   
>    |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 319, in
>    |   main
>    |   
>    |     glob(args[1:], parser.print_help)
>    |   
>    |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 143, in
>    |   glob
>    |   
>    |     if debug:
>    | NameError: global name 'debug' is not defined
> 
> The attached patch fixes the problem, but I'm not sure if it is 100%
> correct.

Oops. I'm working on a proper fix now, sorry for the hassle...

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Can't build any images
  2013-10-29 15:15 ` Paul Eggleton
@ 2013-10-29 15:32   ` Gary Thomas
  0 siblings, 0 replies; 3+ messages in thread
From: Gary Thomas @ 2013-10-29 15:32 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: yocto

On 2013-10-29 09:15, Paul Eggleton wrote:
> On Tuesday 29 October 2013 09:08:01 Gary Thomas wrote:
>> Since this commit:
>>     commit 8b42409dca729b7abbbdac04f533e161de86a3ef
>>     Author: Paul Eggleton <paul.eggleton@linux.intel.com>
>>     Date:   Fri Oct 18 15:19:58 2013 +0100
>>
>>       scripts/oe-pkgdata-util: improve help text and command line parsing
>>
>>       * Use optparse to parse command line
>>       * Make help text actually helpful by describing what each command does
>>       * Drop comment at the top listing the commands which is now superfluous
>>
>>       (From OE-Core rev: feb317513fff638ad7abdba8ab34b8413f0ab055)
>>
>>       Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
>>       Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>
>> I get these errors for any image I try to create:
>>     | Traceback (most recent call last):
>>     |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 334, in
>>     |   <module>   |
>>     |     main()
>>     |
>>     |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 319, in
>>     |   main
>>     |
>>     |     glob(args[1:], parser.print_help)
>>     |
>>     |   File "/local/poky-cutting-edge/scripts/oe-pkgdata-util", line 143, in
>>     |   glob
>>     |
>>     |     if debug:
>>     | NameError: global name 'debug' is not defined
>>
>> The attached patch fixes the problem, but I'm not sure if it is 100%
>> correct.
>
> Oops. I'm working on a proper fix now, sorry for the hassle...

I just tested the patch you send to the OE-core list & it works great.

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-29 15:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 15:08 Can't build any images Gary Thomas
2013-10-29 15:15 ` Paul Eggleton
2013-10-29 15:32   ` Gary Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.