[U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic

[U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic

[Fabio Estevam]

Currently the HDMI splash screen image quality on mx6solo does not show a 
very stable image. 

By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, 
we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.

[U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic

[Eric Nelson]

Thanks Fabio,

On 10/29/2013 10:46 AM, Fabio Estevam wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a
> very stable image.
>
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
>
>  From FSL BSP [1] we have:
>
> 	if (!sig.clk_pol)
> 		di_gen |= DI_GEN_POLARITY_DISP_CLK;
>
> Applying the same logic into U-boot fixes the HDMI image stability.
>

It's odd that this doesn't appear to change things for the i.MX6DQ,
but it works on either one, so

Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>

[U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic

[Stefano Babic]

On 29/10/2013 18:46, Fabio Estevam wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a 
> very stable image. 
> 
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, 
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
> 
> From FSL BSP [1] we have:
> 
> 	if (!sig.clk_pol)
> 		di_gen |= DI_GEN_POLARITY_DISP_CLK;
> 
> Applying the same logic into U-boot fixes the HDMI image stability.
> 
> [1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/video/ipu_disp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
> index 2e91356..22ac142 100644
> --- a/drivers/video/ipu_disp.c
> +++ b/drivers/video/ipu_disp.c
> @@ -1178,7 +1178,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,
>  		if (sig.Vsync_pol)
>  			di_gen |= DI_GEN_POLARITY_3;
>  
> -		if (sig.clk_pol)
> +		if (!sig.clk_pol)
>  			di_gen |= DI_GEN_POL_CLK;
>  
>  	}
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic

[Anatolij Gustschin]

On Tue, 29 Oct 2013 15:46:21 -0200
Fabio Estevam <fabio.estevam@freescale.com> wrote:

> Currently the HDMI splash screen image quality on mx6solo does not show a 
> very stable image. 
> 
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, 
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
> 
> From FSL BSP [1] we have:
> 
> 	if (!sig.clk_pol)
> 		di_gen |= DI_GEN_POLARITY_DISP_CLK;
> 
> Applying the same logic into U-boot fixes the HDMI image stability.
> 
> [1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/video/ipu_disp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-video/master.

Thanks,

Anatolij