From: Eric Blake <eblake@redhat.com>
To: Amos Kong <kongjianjun@gmail.com>, Amos Kong <akong@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial@nongnu.org, mjt@tls.msk.ru,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] move BlockdevRef definition before using it
Date: Wed, 30 Oct 2013 06:32:19 -0600 [thread overview]
Message-ID: <5270FC53.5060002@redhat.com> (raw)
In-Reply-To: <CAFeW=pYtDWzZo8CRtp_CzJFAtt4_ycZRG-45i+agEM6uz-4R=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On 10/30/2013 01:04 AM, Amos Kong wrote:
> On Wed, Oct 30, 2013 at 2:52 PM, Amos Kong <akong@redhat.com> wrote:
>>
>> From: Amos Kong <kongjianjun@gmail.com>
>>
>> @BlockdevRef is used in @BlockdevOptionsGenericFormat and
>> @BlockdevOptionsGenericCOWFormat.
>
> NACK this patch.
>
> @BlockdevOptions is used in @BlockdevRef, this change is meaningless.
Furthermore, qapi allows circular recursive types, so we can't do full
topological sorting (the generator handles a reference to a type before
its declaration just fine, as long as all names encountered in the file
can be resolved at the time the complete file has been parsed).
If anything, I think that alphabetical ordering _might_ make it easier
to find types, instead of the current ad hoc ordering. Also, at one
point there was a patch proposed to allow file inclusion, where you
could break out related types/commands into a secondary file rather than
cramming everything into qapi-schema.json, but I don't know if that's
worth reviving.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Amos Kong <kongjianjun@gmail.com>, Amos Kong <akong@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial@nongnu.org, mjt@tls.msk.ru,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] move BlockdevRef definition before using it
Date: Wed, 30 Oct 2013 06:32:19 -0600 [thread overview]
Message-ID: <5270FC53.5060002@redhat.com> (raw)
In-Reply-To: <CAFeW=pYtDWzZo8CRtp_CzJFAtt4_ycZRG-45i+agEM6uz-4R=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On 10/30/2013 01:04 AM, Amos Kong wrote:
> On Wed, Oct 30, 2013 at 2:52 PM, Amos Kong <akong@redhat.com> wrote:
>>
>> From: Amos Kong <kongjianjun@gmail.com>
>>
>> @BlockdevRef is used in @BlockdevOptionsGenericFormat and
>> @BlockdevOptionsGenericCOWFormat.
>
> NACK this patch.
>
> @BlockdevOptions is used in @BlockdevRef, this change is meaningless.
Furthermore, qapi allows circular recursive types, so we can't do full
topological sorting (the generator handles a reference to a type before
its declaration just fine, as long as all names encountered in the file
can be resolved at the time the complete file has been parsed).
If anything, I think that alphabetical ordering _might_ make it easier
to find types, instead of the current ad hoc ordering. Also, at one
point there was a patch proposed to allow file inclusion, where you
could break out related types/commands into a secondary file rather than
cramming everything into qapi-schema.json, but I don't know if that's
worth reviving.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-30 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 6:52 [Qemu-trivial] [PATCH] move BlockdevRef definition before using it Amos Kong
2013-10-30 6:52 ` [Qemu-devel] " Amos Kong
2013-10-30 7:04 ` [Qemu-trivial] " Amos Kong
2013-10-30 7:04 ` Amos Kong
2013-10-30 12:32 ` Eric Blake [this message]
2013-10-30 12:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5270FC53.5060002@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=kongjianjun@gmail.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.