From: Gary Thomas <gary@mlbassoc.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] core-image-basic.bb: Allow user extensions
Date: Wed, 30 Oct 2013 08:55:09 -0600 [thread overview]
Message-ID: <52711DCD.7080401@mlbassoc.com> (raw)
In-Reply-To: <2034563.H7dbApMjKG@helios>
On 2013-10-30 08:47, Paul Eggleton wrote:
> Hi Gary,
>
> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>> Allow the user to provide additional packages to this image.
>> This lets core-image-basic behave like all other core-image*
>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>> as match the documentation which suggests this as the mode to
>> extend any core-image* image.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>> meta/recipes-extended/images/core-image-basic.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>> 100644
>> --- a/meta/recipes-extended/images/core-image-basic.bb
>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>> @@ -3,9 +3,12 @@ functionality installed."
>> IMAGE_FEATURES += "splash ssh-server-openssh"
>> +CORE_IMAGE_EXTRA_INSTALL ?= ""
>> +
>
> Not sure if it's my mail client but the above looks slightly mangled; in any
> case the above addition shouldn't be needed because core-image.bbclass already
> does this.
Are you sure it counts? core-image.bbclass is included after this would be evaluated,
or does that not matter?
>
>> IMAGE_INSTALL = "\
>> packagegroup-core-boot \
>> packagegroup-core-basic \
>> + ${CORE_IMAGE_EXTRA_INSTALL} \
>> "
>> inherit core-image
>
> Good catch on this one though.
>
> Cheers,
> Paul
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2013-10-30 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 14:22 [PATCH] core-image-basic.bb: Allow user extensions Gary Thomas
2013-10-30 14:47 ` Paul Eggleton
2013-10-30 14:55 ` Gary Thomas [this message]
2013-10-30 15:33 ` Paul Eggleton
2013-10-30 15:40 ` Gary Thomas
2013-10-30 15:42 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52711DCD.7080401@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.