From: Seiji Aguchi <seiji.aguchi@hds.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: hpa@zytor.com, rostedt@goodmis.org, mingo@elte.hu, bp@alien8.de,
tglx@linutronix.de, fdeslaur@gmail.com,
raphael.beamonte@gmail.com, dle-develop@lists.sourceforge.net,
tomoki.sekiyama@hds.com
Subject: [PATCH v4 3/4] Delete __trace_alloc_intr_gate()
Date: Wed, 30 Oct 2013 16:37:47 -0400 [thread overview]
Message-ID: <52716E1B.7090205@hds.com> (raw)
In-Reply-To: <52716D74.3070201@hds.com>
Currently irq vector handlers for tracing are registered in both set_intr_gate()
and __trace_alloc_intr_gate() in alloc_intr_gate().
But, we don't need to do that twice.
So, let's delete __trace_alloc_intr_gate().
Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
---
arch/x86/include/asm/desc.h | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/arch/x86/include/asm/desc.h b/arch/x86/include/asm/desc.h
index 3d73437..50d033a 100644
--- a/arch/x86/include/asm/desc.h
+++ b/arch/x86/include/asm/desc.h
@@ -392,32 +392,10 @@ static inline void alloc_system_vector(int vector)
}
}
-#ifdef CONFIG_TRACING
-static inline void trace_set_intr_gate(unsigned int gate, void *addr)
-{
- gate_desc s;
-
- pack_gate(&s, GATE_INTERRUPT, (unsigned long)addr, 0, 0, __KERNEL_CS);
- write_idt_entry(trace_idt_table, gate, &s);
-}
-
-static inline void __trace_alloc_intr_gate(unsigned int n, void *addr)
-{
- trace_set_intr_gate(n, addr);
-}
-#else
-static inline void trace_set_intr_gate(unsigned int gate, void *addr)
-{
-}
-
-#define __trace_alloc_intr_gate(n, addr)
-#endif
-
#define alloc_intr_gate(n, addr) \
do { \
alloc_system_vector(n); \
set_intr_gate(n, addr); \
- __trace_alloc_intr_gate(n, trace_##addr); \
} while (0)
/*
--
1.8.3.1
next prev parent reply other threads:[~2013-10-30 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 20:35 [PATCH v4 0/4] Introduce page fault tracepoints Seiji Aguchi
2013-10-30 20:36 ` [PATCH v4 1/4] Move set_intr_gate() into macro Seiji Aguchi
2013-11-08 23:09 ` [tip:x86/trace] x86, trace: Remove __alloc_intr_gate() tip-bot for Seiji Aguchi
2013-10-30 20:37 ` [PATCH v4 2/4] Register exception handler to trace IDT Seiji Aguchi
2013-11-08 23:10 ` [tip:x86/trace] x86, trace: " tip-bot for Seiji Aguchi
2013-10-30 20:37 ` Seiji Aguchi [this message]
2013-11-08 23:10 ` [tip:x86/trace] x86, trace: Delete __trace_alloc_intr_gate() tip-bot for Seiji Aguchi
2013-10-30 20:39 ` [PATCH v4 4/4] Add page fault tracepoints Seiji Aguchi
2013-11-08 23:10 ` [tip:x86/trace] x86, trace: " tip-bot for Seiji Aguchi
2013-11-11 8:29 ` Ingo Molnar
2013-11-11 16:01 ` H. Peter Anvin
2013-11-11 16:02 ` Seiji Aguchi
2013-11-11 20:38 ` Ingo Molnar
2013-11-11 16:22 ` [tip:x86/trace] x86, trace: Change user|kernel_page_fault to page_fault_user|kernel tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52716E1B.7090205@hds.com \
--to=seiji.aguchi@hds.com \
--cc=bp@alien8.de \
--cc=dle-develop@lists.sourceforge.net \
--cc=fdeslaur@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=raphael.beamonte@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tomoki.sekiyama@hds.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.