From: "tip-bot for H. Peter Anvin" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
seiji.aguchi@hds.com, tglx@linutronix.de
Subject: [tip:x86/trace] x86, trace: Change user|kernel_page_fault to page_fault_user|kernel
Date: Mon, 11 Nov 2013 08:22:10 -0800 [thread overview]
Message-ID: <tip-a4f61dec55c1bdebb84ba77212ebf98f7247736c@git.kernel.org> (raw)
In-Reply-To: <20131111082955.GB12405@gmail.com>
Commit-ID: a4f61dec55c1bdebb84ba77212ebf98f7247736c
Gitweb: http://git.kernel.org/tip/a4f61dec55c1bdebb84ba77212ebf98f7247736c
Author: H. Peter Anvin <hpa@zytor.com>
AuthorDate: Mon, 11 Nov 2013 08:15:40 -0800
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 11 Nov 2013 08:15:40 -0800
x86, trace: Change user|kernel_page_fault to page_fault_user|kernel
Tracepoints are named hierachially, and it makes more sense to keep a
general flow of information level from general to specific from left
to right, i.e.
x86_exceptions.page_fault_user|kernel
rather than
x86_exceptions.user|kernel_page_fault
Suggested-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Seiji Aguchi <seiji.aguchi@hds.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Link: http://lkml.kernel.org/r/20131111082955.GB12405@gmail.com
---
arch/x86/include/asm/trace/exceptions.h | 4 ++--
arch/x86/mm/fault.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/trace/exceptions.h b/arch/x86/include/asm/trace/exceptions.h
index 86540c0..2fbc66c 100644
--- a/arch/x86/include/asm/trace/exceptions.h
+++ b/arch/x86/include/asm/trace/exceptions.h
@@ -40,8 +40,8 @@ DEFINE_EVENT_FN(x86_exceptions, name, \
trace_irq_vector_regfunc, \
trace_irq_vector_unregfunc);
-DEFINE_PAGE_FAULT_EVENT(user_page_fault);
-DEFINE_PAGE_FAULT_EVENT(kernel_page_fault);
+DEFINE_PAGE_FAULT_EVENT(page_fault_user);
+DEFINE_PAGE_FAULT_EVENT(page_fault_kernel);
#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH .
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index f2730cbc..e532230 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -1239,9 +1239,9 @@ static void trace_page_fault_entries(struct pt_regs *regs,
unsigned long error_code)
{
if (user_mode(regs))
- trace_user_page_fault(read_cr2(), regs, error_code);
+ trace_page_fault_user(read_cr2(), regs, error_code);
else
- trace_kernel_page_fault(read_cr2(), regs, error_code);
+ trace_page_fault_kernel(read_cr2(), regs, error_code);
}
dotraplinkage void __kprobes
prev parent reply other threads:[~2013-11-11 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 20:35 [PATCH v4 0/4] Introduce page fault tracepoints Seiji Aguchi
2013-10-30 20:36 ` [PATCH v4 1/4] Move set_intr_gate() into macro Seiji Aguchi
2013-11-08 23:09 ` [tip:x86/trace] x86, trace: Remove __alloc_intr_gate() tip-bot for Seiji Aguchi
2013-10-30 20:37 ` [PATCH v4 2/4] Register exception handler to trace IDT Seiji Aguchi
2013-11-08 23:10 ` [tip:x86/trace] x86, trace: " tip-bot for Seiji Aguchi
2013-10-30 20:37 ` [PATCH v4 3/4] Delete __trace_alloc_intr_gate() Seiji Aguchi
2013-11-08 23:10 ` [tip:x86/trace] x86, trace: " tip-bot for Seiji Aguchi
2013-10-30 20:39 ` [PATCH v4 4/4] Add page fault tracepoints Seiji Aguchi
2013-11-08 23:10 ` [tip:x86/trace] x86, trace: " tip-bot for Seiji Aguchi
2013-11-11 8:29 ` Ingo Molnar
2013-11-11 16:01 ` H. Peter Anvin
2013-11-11 16:02 ` Seiji Aguchi
2013-11-11 20:38 ` Ingo Molnar
2013-11-11 16:22 ` tip-bot for H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a4f61dec55c1bdebb84ba77212ebf98f7247736c@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.