From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pkrempa@redhat.com, lersek@redhat.com, marcel.a@redhat.com,
libvir-list@redhat.com, Hu Tao <hutao@cn.fujitsu.com>,
qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com,
kraxel@redhat.com, anthony@codemonkey.ws, lcapitulino@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] pvpanic plans?
Date: Thu, 31 Oct 2013 17:52:11 +0100 [thread overview]
Message-ID: <52728ABB.2030808@redhat.com> (raw)
In-Reply-To: <20131031164828.GA10862@redhat.com>
Il 31/10/2013 17:48, Michael S. Tsirkin ha scritto:
> But code duplication is bad.
So should we make a table of IO_ERROR-like states to avoid code
duplication? You have to draw a line somewhere...
> I think IO error for example
> is broken in that you can't pause but can run then pause.
> Seems strange.
"cont" moves you out of IO_ERROR. IO_ERROR is already a non-running
state (all states except RUNNING are non-running), "stop" is a no-op in
non-running states. I don't like it that much either, but it works.
Paolo
next prev parent reply other threads:[~2013-10-31 16:52 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 16:10 [Qemu-devel] pvpanic plans? Paolo Bonzini
2013-08-22 16:44 ` Anthony Liguori
2013-08-22 17:53 ` Laszlo Ersek
2013-08-22 18:25 ` Anthony Liguori
2013-08-27 8:42 ` Richard W.M. Jones
2013-08-22 19:16 ` Paolo Bonzini
2013-08-22 20:09 ` Anthony Liguori
2013-08-22 20:36 ` Laszlo Ersek
2013-08-22 20:39 ` Anthony Liguori
2013-08-23 8:52 ` Paolo Bonzini
2013-08-22 21:08 ` Peter Maydell
2013-08-27 8:06 ` Richard W.M. Jones
2013-08-27 13:08 ` Ronen Hod
2013-08-27 13:20 ` Richard W.M. Jones
2013-08-27 13:26 ` Anthony Liguori
2013-08-27 13:57 ` Richard W.M. Jones
2013-08-27 13:13 ` [Qemu-devel] [libvirt] " Daniel P. Berrange
2013-08-27 13:17 ` Anthony Liguori
2013-08-27 13:21 ` Richard W.M. Jones
2013-08-22 17:15 ` [Qemu-devel] " Laszlo Ersek
2013-08-22 18:33 ` Anthony Liguori
2013-08-22 19:44 ` Christian Borntraeger
2013-08-22 19:19 ` Paolo Bonzini
2013-08-22 19:41 ` Laszlo Ersek
2013-08-22 20:02 ` [Qemu-devel] [libvirt] " Eric Blake
2013-10-24 2:39 ` [Qemu-devel] " Hu Tao
2013-10-29 16:01 ` Markus Armbruster
2013-10-31 14:30 ` Michael S. Tsirkin
2013-10-31 14:32 ` Eric Blake
2013-10-31 14:34 ` Anthony Liguori
2013-10-31 14:39 ` Paolo Bonzini
2013-10-31 14:52 ` Michael S. Tsirkin
2013-10-31 14:56 ` Paolo Bonzini
2013-10-31 15:09 ` Michael S. Tsirkin
2013-10-31 15:26 ` Paolo Bonzini
2013-10-31 15:45 ` Michael S. Tsirkin
2013-10-31 15:56 ` Paolo Bonzini
2013-10-31 16:14 ` Michael S. Tsirkin
2013-10-31 16:17 ` Paolo Bonzini
2013-10-31 16:26 ` Michael S. Tsirkin
2013-10-31 16:38 ` Paolo Bonzini
2013-10-31 16:48 ` Michael S. Tsirkin
2013-10-31 16:52 ` Paolo Bonzini [this message]
2013-10-31 17:00 ` Michael S. Tsirkin
2013-10-31 17:09 ` Paolo Bonzini
2013-10-31 17:01 ` Michael S. Tsirkin
2013-10-31 17:10 ` Paolo Bonzini
2013-10-31 17:18 ` Michael S. Tsirkin
2013-10-31 18:03 ` Paolo Bonzini
2013-10-31 16:28 ` Michael S. Tsirkin
2013-10-31 14:47 ` Michael S. Tsirkin
2013-10-31 14:49 ` Eric Blake
2013-10-31 15:07 ` Michael S. Tsirkin
2013-11-04 9:25 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52728ABB.2030808@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.