From: Jason Wang <jasowang@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
mst@redhat.com, mwdalton@google.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 2/2] virtio-net: coalesce rx frags when possible during rx
Date: Fri, 01 Nov 2013 13:37:02 +0800 [thread overview]
Message-ID: <52733DFE.7090704@redhat.com> (raw)
In-Reply-To: <87iowcc1id.fsf@rustcorp.com.au>
On 11/01/2013 10:13 AM, Rusty Russell wrote:
> Jason Wang <jasowang@redhat.com> writes:
>> Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable
>> rx buffers to page frag allocators) try to increase the payload/truesize for
>> MTU-sized traffic. But this will introduce the extra overhead for GSO packets
>> received because of the frag list. This commit tries to reduce this issue by
>> coalesce the possible rx frags when possible during rx. Test result shows the
>> about 15% improvement on full size GSO packet receiving (and even better than
>> commit 2613af0ed18a11d5c566a81f9a6510b73180660a).
> I don't know about the other users of skb_add_rx_frag, but should
> this coalesce-if-possible code be built into that?
There're several other users without the possibility check. And Eric
point out in do_tcp_sendpages() skb_add_rx_frag() and skb_can_coalesce()
were used separatedly which can allows us to do some other things in the
middle. So it was ok here.
>
> Thanks,
> Rusty.
next prev parent reply other threads:[~2013-11-01 5:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 10:28 [PATCH net-next 1/2] net: introduce skb_coalesce_rx_frag() Jason Wang
2013-10-31 10:28 ` Jason Wang
2013-10-31 10:28 ` [PATCH net-next 2/2] virtio-net: coalesce rx frags when possible during rx Jason Wang
2013-10-31 10:28 ` Jason Wang
2013-10-31 11:41 ` Michael S. Tsirkin
2013-10-31 11:41 ` Michael S. Tsirkin
2013-11-01 2:13 ` Rusty Russell
2013-11-01 2:13 ` Rusty Russell
2013-11-01 5:37 ` Jason Wang [this message]
2013-10-31 11:05 ` [PATCH net-next 1/2] net: introduce skb_coalesce_rx_frag() Kmindg G
2013-10-31 11:34 ` Jason Wang
2013-10-31 11:34 ` Jason Wang
2013-10-31 11:05 ` Kmindg G
2013-10-31 11:41 ` Michael S. Tsirkin
2013-10-31 11:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52733DFE.7090704@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mwdalton@google.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.