All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jason Wang <jasowang@redhat.com>,
	davem@davemloft.net, edumazet@google.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	mst@redhat.com, mwdalton@google.com,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 2/2] virtio-net: coalesce rx frags when possible during rx
Date: Fri, 01 Nov 2013 12:43:46 +1030	[thread overview]
Message-ID: <87iowcc1id.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1383215313-23651-2-git-send-email-jasowang@redhat.com>

Jason Wang <jasowang@redhat.com> writes:
> Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable
> rx buffers to page frag allocators) try to increase the payload/truesize for
> MTU-sized traffic. But this will introduce the extra overhead for GSO packets
> received because of the frag list. This commit tries to reduce this issue by
> coalesce the possible rx frags when possible during rx. Test result shows the
> about 15% improvement on full size GSO packet receiving (and even better than
> commit 2613af0ed18a11d5c566a81f9a6510b73180660a).

I don't know about the other users of skb_add_rx_frag, but should
this coalesce-if-possible code be built into that?

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jason Wang <jasowang@redhat.com>,
	davem@davemloft.net, edumazet@google.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	mst@redhat.com, mwdalton@google.com,
	virtualization@lists.linux-foundation.org
Cc: Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH net-next 2/2] virtio-net: coalesce rx frags when possible during rx
Date: Fri, 01 Nov 2013 12:43:46 +1030	[thread overview]
Message-ID: <87iowcc1id.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1383215313-23651-2-git-send-email-jasowang@redhat.com>

Jason Wang <jasowang@redhat.com> writes:
> Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable
> rx buffers to page frag allocators) try to increase the payload/truesize for
> MTU-sized traffic. But this will introduce the extra overhead for GSO packets
> received because of the frag list. This commit tries to reduce this issue by
> coalesce the possible rx frags when possible during rx. Test result shows the
> about 15% improvement on full size GSO packet receiving (and even better than
> commit 2613af0ed18a11d5c566a81f9a6510b73180660a).

I don't know about the other users of skb_add_rx_frag, but should
this coalesce-if-possible code be built into that?

Thanks,
Rusty.

  parent reply	other threads:[~2013-11-01  2:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31 10:28 [PATCH net-next 1/2] net: introduce skb_coalesce_rx_frag() Jason Wang
2013-10-31 10:28 ` Jason Wang
2013-10-31 10:28 ` [PATCH net-next 2/2] virtio-net: coalesce rx frags when possible during rx Jason Wang
2013-10-31 10:28   ` Jason Wang
2013-10-31 11:41   ` Michael S. Tsirkin
2013-10-31 11:41     ` Michael S. Tsirkin
2013-11-01  2:13   ` Rusty Russell [this message]
2013-11-01  2:13     ` Rusty Russell
2013-11-01  5:37     ` Jason Wang
2013-10-31 11:05 ` [PATCH net-next 1/2] net: introduce skb_coalesce_rx_frag() Kmindg G
2013-10-31 11:05 ` Kmindg G
2013-10-31 11:34   ` Jason Wang
2013-10-31 11:34     ` Jason Wang
2013-10-31 11:41 ` Michael S. Tsirkin
2013-10-31 11:41   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iowcc1id.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mwdalton@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.