All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-trivial] [PATCH] vl: fix build when configured with no graphic support
Date: Fri, 01 Nov 2013 14:29:24 +0400	[thread overview]
Message-ID: <52738284.5090708@msgid.tls.msk.ru> (raw)
In-Reply-To: <1383021391-3152-1-git-send-email-antonynpavlov@gmail.com>

29.10.2013 08:36, Antony Pavlov wrote
> The following error occurs when building no graphic output support:
>
>    vl.c: In function ‘main’:
>    vl.c:2829:19: error: variable ‘ds’ set but not used [-Werror=unused-but-set-variable]
>         DisplayState *ds;
>                       ^
>    cc1: all warnings being treated as errors

Thanks, applied to the trivial-patches queue.

While at it, I also added a comment to the line being added,
telling what this is all about:

--- a/vl.c
+++ b/vl.c
@@ -4269,6 +4269,7 @@ int main(int argc, char **argv, char **envp)
      /* init local displays */
      switch (display_type) {
      case DT_NOGRAPHIC:
+        (void)ds;      /* avoid warning if no display is configured */
          break;
  #if defined(CONFIG_CURSES)
      case DT_CURSES:

Hopefully it is okay... ;)

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: fix build when configured with no graphic support
Date: Fri, 01 Nov 2013 14:29:24 +0400	[thread overview]
Message-ID: <52738284.5090708@msgid.tls.msk.ru> (raw)
In-Reply-To: <1383021391-3152-1-git-send-email-antonynpavlov@gmail.com>

29.10.2013 08:36, Antony Pavlov wrote
> The following error occurs when building no graphic output support:
>
>    vl.c: In function ‘main’:
>    vl.c:2829:19: error: variable ‘ds’ set but not used [-Werror=unused-but-set-variable]
>         DisplayState *ds;
>                       ^
>    cc1: all warnings being treated as errors

Thanks, applied to the trivial-patches queue.

While at it, I also added a comment to the line being added,
telling what this is all about:

--- a/vl.c
+++ b/vl.c
@@ -4269,6 +4269,7 @@ int main(int argc, char **argv, char **envp)
      /* init local displays */
      switch (display_type) {
      case DT_NOGRAPHIC:
+        (void)ds;      /* avoid warning if no display is configured */
          break;
  #if defined(CONFIG_CURSES)
      case DT_CURSES:

Hopefully it is okay... ;)

/mjt

  parent reply	other threads:[~2013-11-01 10:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  4:36 [Qemu-trivial] [PATCH] vl: fix build when configured with no graphic support Antony Pavlov
2013-10-29  4:36 ` [Qemu-devel] " Antony Pavlov
2013-10-29  5:19 ` [Qemu-trivial] " Stefan Weil
2013-10-29  5:19   ` Stefan Weil
2013-11-01 10:29 ` Michael Tokarev [this message]
2013-11-01 10:29   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-11-01 11:14   ` Antony Pavlov
2013-11-01 11:14     ` [Qemu-devel] " Antony Pavlov
2013-11-01 11:18     ` Michael Tokarev
2013-11-01 11:18       ` [Qemu-devel] " Michael Tokarev
2013-11-01 12:54       ` Antony Pavlov
2013-11-01 12:54         ` [Qemu-devel] " Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52738284.5090708@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=aliguori@amazon.com \
    --cc=antonynpavlov@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.