From: walter harms <wharms@bfs.de>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Veaceslav Falico <vfalico@redhat.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bonding: bond_get_size() returns wrong size
Date: Fri, 01 Nov 2013 12:30:58 +0000 [thread overview]
Message-ID: <52739F02.80900@bfs.de> (raw)
In-Reply-To: <52739DAC.4000309@redhat.com>
Am 01.11.2013 13:25, schrieb Nikolay Aleksandrov:
> On 11/01/2013 12:35 PM, Jiri Pirko wrote:
>> Fri, Nov 01, 2013 at 11:41:00AM CET, vfalico@redhat.com wrote:
>>> On Fri, Nov 01, 2013 at 01:18:44PM +0300, Dan Carpenter wrote:
>>>> There is an extra semi-colon so bond_get_size() doesn't return the
>>>> correct value.
>>>>
>>>> Fixes: ec76aa49855f ('bonding: add Netlink support active_slave option')
>>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> Hrm, how does it even build. Good catch, thanks.
>>
>> I wonder about the same thing.
>>
> + and - can be unary operators so it's a valid expression :-)
> Nice catch
>
NTL my gcc warns (-Wall)
warning: statement with no effect
this should come up.
re,
wh
> Nik
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Veaceslav Falico <vfalico@redhat.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bonding: bond_get_size() returns wrong size
Date: Fri, 01 Nov 2013 13:30:58 +0100 [thread overview]
Message-ID: <52739F02.80900@bfs.de> (raw)
In-Reply-To: <52739DAC.4000309@redhat.com>
Am 01.11.2013 13:25, schrieb Nikolay Aleksandrov:
> On 11/01/2013 12:35 PM, Jiri Pirko wrote:
>> Fri, Nov 01, 2013 at 11:41:00AM CET, vfalico@redhat.com wrote:
>>> On Fri, Nov 01, 2013 at 01:18:44PM +0300, Dan Carpenter wrote:
>>>> There is an extra semi-colon so bond_get_size() doesn't return the
>>>> correct value.
>>>>
>>>> Fixes: ec76aa49855f ('bonding: add Netlink support active_slave option')
>>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> Hrm, how does it even build. Good catch, thanks.
>>
>> I wonder about the same thing.
>>
> + and - can be unary operators so it's a valid expression :-)
> Nice catch
>
NTL my gcc warns (-Wall)
warning: statement with no effect
this should come up.
re,
wh
> Nik
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-11-01 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 10:18 [patch -next] bonding: bond_get_size() returns wrong size Dan Carpenter
2013-11-01 10:18 ` Dan Carpenter
2013-11-01 10:41 ` Veaceslav Falico
2013-11-01 10:41 ` Veaceslav Falico
2013-11-01 10:52 ` Eric Dumazet
2013-11-01 10:52 ` Eric Dumazet
2013-11-01 11:35 ` Jiri Pirko
2013-11-01 11:35 ` Jiri Pirko
2013-11-01 12:25 ` Nikolay Aleksandrov
2013-11-01 12:25 ` Nikolay Aleksandrov
2013-11-01 12:30 ` walter harms [this message]
2013-11-01 12:30 ` walter harms
2013-11-02 6:09 ` David Miller
2013-11-02 6:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52739F02.80900@bfs.de \
--to=wharms@bfs.de \
--cc=andy@greyhouse.net \
--cc=dan.carpenter@oracle.com \
--cc=fubar@us.ibm.com \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.