From: Tim Gardner <timg-l6nL5VImRDY@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
samba-technical
<samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire
Date: Fri, 01 Nov 2013 12:04:44 -0700 [thread overview]
Message-ID: <5273FB4C.5010002@tpi.com> (raw)
In-Reply-To: <CAH2r5mt5kBDR1oZfDNVu+bd7-jf=zQ6tBm2YjKXKBwdYE+YG=w@mail.gmail.com>
On 11/01/2013 11:50 AM, Steve French wrote:
> This has a couple of obvious endian errors. I will correct your patch
> and remerge into cifs-2.6.git for-next
>
> Please always remember to run endian checks against cifs builds when
> submitting a patch (and make sure sparse is installed)
>
> e.g.
>
> make C=1 M=fs/cifs modules CF=-D__CHECK_ENDIAN__
>
Didn't know about __CHECK_ENDIAN__, but will do so in the future. Your
changes look fine.
rtg
--
Tim Gardner timg-l6nL5VImRDY@public.gmane.org www.tpi.com
OR 503-601-0234 x102 MT 406-443-5357
WARNING: multiple messages have this Message-ID (diff)
From: Tim Gardner <timg@tpi.com>
To: Steve French <smfrench@gmail.com>
Cc: "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>,
Jeff Layton <jlayton@redhat.com>,
Steve French <sfrench@samba.org>
Subject: Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire
Date: Fri, 01 Nov 2013 12:04:44 -0700 [thread overview]
Message-ID: <5273FB4C.5010002@tpi.com> (raw)
In-Reply-To: <CAH2r5mt5kBDR1oZfDNVu+bd7-jf=zQ6tBm2YjKXKBwdYE+YG=w@mail.gmail.com>
On 11/01/2013 11:50 AM, Steve French wrote:
> This has a couple of obvious endian errors. I will correct your patch
> and remerge into cifs-2.6.git for-next
>
> Please always remember to run endian checks against cifs builds when
> submitting a patch (and make sure sparse is installed)
>
> e.g.
>
> make C=1 M=fs/cifs modules CF=-D__CHECK_ENDIAN__
>
Didn't know about __CHECK_ENDIAN__, but will do so in the future. Your
changes look fine.
rtg
--
Tim Gardner timg@tpi.com www.tpi.com
OR 503-601-0234 x102 MT 406-443-5357
next prev parent reply other threads:[~2013-11-01 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 16:32 [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire Tim Gardner
2013-10-16 16:32 ` Tim Gardner
[not found] ` <1381941162-72831-1-git-send-email-timg-l6nL5VImRDY@public.gmane.org>
2013-10-16 20:03 ` Jeff Layton
2013-10-16 20:03 ` Jeff Layton
[not found] ` <20131016160334.61dc2a5c-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-10-28 14:38 ` Steve French
2013-10-28 14:38 ` Steve French
2013-11-01 18:50 ` Steve French
2013-11-01 18:50 ` Steve French
2013-11-01 19:04 ` Tim Gardner [this message]
2013-11-01 19:04 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5273FB4C.5010002@tpi.com \
--to=timg-l6nl5vimrdy@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.