Fwd: [PATCH v2] kernel/resource.c: use signed length comparing instead of position comparing

Fwd: [PATCH v2] kernel/resource.c: use signed length comparing instead of position comparing

[Chen Gang]

Sorry, forgot to cc linux-kernel.


-------- Original Message --------
Subject: [PATCH v2] kernel/resource.c: use signed length comparing instead of position comparing
Date: Mon, 04 Nov 2013 11:05:30 +0800
From: Chen Gang <gang.chen@asianux.com>
To: Toshi Kani <toshi.kani@hp.com>,  "isimatu.yasuaki@jp.fujitsu.com" <isimatu.yasuaki@jp.fujitsu.com>, gong.chen@linux.intel.com, haokexin@gmail.com
CC: Andrew Morton <akpm@linux-foundation.org>

Theoretically, "addr + size" may be overflow (e.g. equal 0), so use
signed length comparing instead of position comparing.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 kernel/resource.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 3f285dc..0783733 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1335,7 +1335,7 @@ int iomem_is_exclusive(u64 addr)
 		 * We can probably skip the resources without
 		 * IORESOURCE_IO attribute?
 		 */
-		if (p->start >= addr + size)
+		if ((s64)(p->start - addr) >= size)
 			break;
 		if (p->end < addr)
 			continue;
-- 
1.7.7.6