From: michael.opdenacker@free-electrons.com (Michael Opdenacker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter
Date: Mon, 04 Nov 2013 10:00:36 +0100 [thread overview]
Message-ID: <52776234.7030901@free-electrons.com> (raw)
In-Reply-To: <20131104085146.GT24559@pengutronix.de>
Hi Sascha,
On 11/04/2013 09:51 AM, Sascha Hauer wrote:
> On Mon, Nov 04, 2013 at 06:19:26AM +0100, Michael Opdenacker wrote:
>> This removes the MACH_MXLADS Kconfig parameter,
>> which was no longer used anywhere in the source code
>> and Makefiles.
> Hehe, this one is a bit tricky. Indeed MACH_MXLADS isn't used directly
> anywhere. Nevertheless having CONFIG_MACH_MXLADS defined makes
> machine_is_mxlads() become true when the kernel is started with a
> machine id of 1851.
Oops, that's right, got it! Thanks!
>
> machine_is_mxlads() is unused in the kernel, so this patch indeed
> doesn't hurt. Anyway, the code is correct currently, so I suggest
> keeping it until the mx[1l]ads is either removed or converted to
> devicetree.
Sounds good to me.
Thanks for your review!
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
WARNING: multiple messages have this Message-ID (diff)
From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: kernel@pengutronix.de, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter
Date: Mon, 04 Nov 2013 10:00:36 +0100 [thread overview]
Message-ID: <52776234.7030901@free-electrons.com> (raw)
In-Reply-To: <20131104085146.GT24559@pengutronix.de>
Hi Sascha,
On 11/04/2013 09:51 AM, Sascha Hauer wrote:
> On Mon, Nov 04, 2013 at 06:19:26AM +0100, Michael Opdenacker wrote:
>> This removes the MACH_MXLADS Kconfig parameter,
>> which was no longer used anywhere in the source code
>> and Makefiles.
> Hehe, this one is a bit tricky. Indeed MACH_MXLADS isn't used directly
> anywhere. Nevertheless having CONFIG_MACH_MXLADS defined makes
> machine_is_mxlads() become true when the kernel is started with a
> machine id of 1851.
Oops, that's right, got it! Thanks!
>
> machine_is_mxlads() is unused in the kernel, so this patch indeed
> doesn't hurt. Anyway, the code is correct currently, so I suggest
> keeping it until the mx[1l]ads is either removed or converted to
> devicetree.
Sounds good to me.
Thanks for your review!
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
next prev parent reply other threads:[~2013-11-04 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 5:19 [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter Michael Opdenacker
2013-11-04 5:19 ` Michael Opdenacker
2013-11-04 8:51 ` Sascha Hauer
2013-11-04 8:51 ` Sascha Hauer
2013-11-04 9:00 ` Michael Opdenacker [this message]
2013-11-04 9:00 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52776234.7030901@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.