From: Daniel Borkmann <dborkman@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] net: sctp: fix and consolidate SCTP checksumming code
Date: Mon, 04 Nov 2013 12:11:34 +0000 [thread overview]
Message-ID: <52778EF6.4000801@redhat.com> (raw)
In-Reply-To: <527117C3.2080306@gmail.com>
On 10/30/2013 03:29 PM, Vlad Yasevich wrote:
> On 10/30/2013 06:50 AM, Daniel Borkmann wrote:
[...]
> Daniel
>
> Here is a follow-on idea that might help even more.
> What if we put a pointer to skb_checksum_ops() in the skb
> somewhere (I was thinking of skb_shinfo). Then
> skb_checksum can simply use the data from there. This would
> allow us to get rid of all the special cases in SCTP that do
> checksumming. We can just set it to partial, set up the right
> fields and let HW or SW always do the right thing.
I need to think about this a bit. This would certainly have the
negative side-effect of a higher skb->truesize usage and thus
affecting memory accounting for everyone as we extend
skb_shared_info.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] net: sctp: fix and consolidate SCTP checksumming code
Date: Mon, 04 Nov 2013 13:11:34 +0100 [thread overview]
Message-ID: <52778EF6.4000801@redhat.com> (raw)
In-Reply-To: <527117C3.2080306@gmail.com>
On 10/30/2013 03:29 PM, Vlad Yasevich wrote:
> On 10/30/2013 06:50 AM, Daniel Borkmann wrote:
[...]
> Daniel
>
> Here is a follow-on idea that might help even more.
> What if we put a pointer to skb_checksum_ops() in the skb
> somewhere (I was thinking of skb_shinfo). Then
> skb_checksum can simply use the data from there. This would
> allow us to get rid of all the special cases in SCTP that do
> checksumming. We can just set it to partial, set up the right
> fields and let HW or SW always do the right thing.
I need to think about this a bit. This would certainly have the
negative side-effect of a higher skb->truesize usage and thus
affecting memory accounting for everyone as we extend
skb_shared_info.
next prev parent reply other threads:[~2013-11-04 12:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 10:50 [PATCH net-next 0/5] SCTP fix/updates Daniel Borkmann
2013-10-30 10:50 ` Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 1/5] lib: crc32: clean up spacing in test cases Daniel Borkmann
2013-10-30 10:50 ` Daniel Borkmann
2013-10-30 13:56 ` Joe Perches
2013-10-30 13:56 ` Joe Perches
2013-10-30 14:10 ` David Laight
2013-10-30 14:10 ` David Laight
2013-10-30 14:15 ` Daniel Borkmann
2013-10-30 14:15 ` Daniel Borkmann
2013-10-30 15:14 ` Joe Perches
2013-10-30 15:14 ` Joe Perches
2013-10-30 10:50 ` [PATCH net-next 2/5] lib: crc32: add functionality to combine two crc32{,c}s in GF(2) Daniel Borkmann
2013-10-30 10:50 ` Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 3/5] lib: crc32: add test cases for crc32{,c}_combine routines Daniel Borkmann
2013-10-30 10:50 ` Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 4/5] net: skb_checksum: allow custom update/combine for walking skb Daniel Borkmann
2013-10-30 10:50 ` Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 5/5] net: sctp: fix and consolidate SCTP checksumming code Daniel Borkmann
2013-10-30 10:50 ` Daniel Borkmann
2013-10-30 14:29 ` Vlad Yasevich
2013-10-30 14:29 ` Vlad Yasevich
2013-11-04 12:11 ` Daniel Borkmann [this message]
2013-11-04 12:11 ` Daniel Borkmann
2013-11-04 16:10 ` Vlad Yasevich
2013-11-04 16:10 ` Vlad Yasevich
2013-11-04 21:10 ` Daniel Borkmann
2013-11-04 21:10 ` Daniel Borkmann
2013-10-30 11:29 ` [PATCH net-next 0/5] SCTP fix/updates Neil Horman
2013-10-30 11:29 ` Neil Horman
2013-10-30 14:29 ` Vlad Yasevich
2013-10-30 14:29 ` Vlad Yasevich
2013-11-04 4:07 ` David Miller
2013-11-04 4:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52778EF6.4000801@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.