All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Vivek Gautam <gautam.vivek@samsung.com>,
	linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	gregkh@linuxfoundation.org, kgene.kim@samsung.com,
	k.debski@samsung.com, s.nawrocki@samsung.com, balbi@ti.com,
	jwerner@chromium.org, jg1.han@samsung.com
Subject: Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver
Date: Mon, 4 Nov 2013 18:39:00 +0530	[thread overview]
Message-ID: <52779C6C.1090603@ti.com> (raw)
In-Reply-To: <1539581.zprt32081v@amdc1227>

On Monday 04 November 2013 05:56 PM, Tomasz Figa wrote:
> Hi Kishon,
>
> On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote:
>> Hi Vivek,
>>
>> On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
>>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
>>> The new driver uses the generic PHY framework and will interact
>>> with DWC3 controller present on Exynos5 series of SoCs.
>>
>> In Exynos, you have a single IP that supports both USB3 and USB2 PHY
>> right? I think that needs to be mentioned here.
>
> Nope. There are two separate, different IPs.

Alright. Thanks for the clarification.

Cheers
Kishon

>
>> Do you have separate registers that should be used for
>> initializing/powerin_on/powering_off etc.. for usb2 phy and usb3 phy? If
>> so, then you should model this driver as a single driver that supports
>> two PHYs similar to what Sylwester has done before?
>
> Sylwester's MIPI PHY uses such model because it has a single register
> that controls both PHYs.
>
> Best regards,
> Tomasz
>

WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver
Date: Mon, 4 Nov 2013 18:39:00 +0530	[thread overview]
Message-ID: <52779C6C.1090603@ti.com> (raw)
In-Reply-To: <1539581.zprt32081v@amdc1227>

On Monday 04 November 2013 05:56 PM, Tomasz Figa wrote:
> Hi Kishon,
>
> On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote:
>> Hi Vivek,
>>
>> On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
>>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
>>> The new driver uses the generic PHY framework and will interact
>>> with DWC3 controller present on Exynos5 series of SoCs.
>>
>> In Exynos, you have a single IP that supports both USB3 and USB2 PHY
>> right? I think that needs to be mentioned here.
>
> Nope. There are two separate, different IPs.

Alright. Thanks for the clarification.

Cheers
Kishon

>
>> Do you have separate registers that should be used for
>> initializing/powerin_on/powering_off etc.. for usb2 phy and usb3 phy? If
>> so, then you should model this driver as a single driver that supports
>> two PHYs similar to what Sylwester has done before?
>
> Sylwester's MIPI PHY uses such model because it has a single register
> that controls both PHYs.
>
> Best regards,
> Tomasz
>

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Vivek Gautam <gautam.vivek@samsung.com>,
	<linux-usb@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-doc@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<kgene.kim@samsung.com>, <k.debski@samsung.com>,
	<s.nawrocki@samsung.com>, <balbi@ti.com>, <jwerner@chromium.org>,
	<jg1.han@samsung.com>
Subject: Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver
Date: Mon, 4 Nov 2013 18:39:00 +0530	[thread overview]
Message-ID: <52779C6C.1090603@ti.com> (raw)
In-Reply-To: <1539581.zprt32081v@amdc1227>

On Monday 04 November 2013 05:56 PM, Tomasz Figa wrote:
> Hi Kishon,
>
> On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote:
>> Hi Vivek,
>>
>> On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
>>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
>>> The new driver uses the generic PHY framework and will interact
>>> with DWC3 controller present on Exynos5 series of SoCs.
>>
>> In Exynos, you have a single IP that supports both USB3 and USB2 PHY
>> right? I think that needs to be mentioned here.
>
> Nope. There are two separate, different IPs.

Alright. Thanks for the clarification.

Cheers
Kishon

>
>> Do you have separate registers that should be used for
>> initializing/powerin_on/powering_off etc.. for usb2 phy and usb3 phy? If
>> so, then you should model this driver as a single driver that supports
>> two PHYs similar to what Sylwester has done before?
>
> Sylwester's MIPI PHY uses such model because it has a single register
> that controls both PHYs.
>
> Best regards,
> Tomasz
>


  reply	other threads:[~2013-11-04 13:09 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31  7:45 [PATCH RFC 0/4] Add Exynos5 USB 3.0 phy driver based on generic PHY framework Vivek Gautam
2013-10-31  7:45 ` Vivek Gautam
2013-10-31  7:45 ` [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver Vivek Gautam
2013-10-31  7:45   ` Vivek Gautam
2013-10-31  7:45   ` Vivek Gautam
2013-11-04  6:54   ` Kishon Vijay Abraham I
2013-11-04  6:54     ` Kishon Vijay Abraham I
2013-11-04  6:54     ` Kishon Vijay Abraham I
2013-11-04 10:15     ` Kamil Debski
2013-11-04 10:15       ` Kamil Debski
2013-11-04 13:12       ` Kishon Vijay Abraham I
2013-11-04 13:12         ` Kishon Vijay Abraham I
2013-11-04 13:12         ` Kishon Vijay Abraham I
2013-11-05  7:20         ` Vivek Gautam
2013-11-05  7:20           ` Vivek Gautam
2013-11-05  9:34           ` Tomasz Figa
2013-11-05  9:34             ` Tomasz Figa
2013-11-05  9:36           ` Kamil Debski
2013-11-05  9:36             ` Kamil Debski
2013-11-05 11:12             ` Jingoo Han
2013-11-05 11:12               ` Jingoo Han
2013-11-05 12:03               ` Jingoo Han
2013-11-05 12:03                 ` Jingoo Han
2013-11-05 17:58                 ` Vivek Gautam
2013-11-05 17:58                   ` Vivek Gautam
2013-11-06  0:07                   ` Jingoo Han
2013-11-06  0:07                     ` Jingoo Han
2013-11-11 11:11                     ` Kishon Vijay Abraham I
2013-11-11 11:11                       ` Kishon Vijay Abraham I
2013-11-11 11:11                       ` Kishon Vijay Abraham I
2013-11-20  8:57                       ` Vivek Gautam
2013-11-20  8:57                         ` Vivek Gautam
2013-11-20  9:04                         ` Kishon Vijay Abraham I
2013-11-20  9:04                           ` Kishon Vijay Abraham I
2013-11-20  9:04                           ` Kishon Vijay Abraham I
2013-11-20  9:32                           ` Vivek Gautam
2013-11-20  9:32                             ` Vivek Gautam
2013-11-20 15:44                             ` Kishon Vijay Abraham I
2013-11-20 15:44                               ` Kishon Vijay Abraham I
2013-11-20 15:44                               ` Kishon Vijay Abraham I
     [not found]                               ` <528CD8EC.9050403-l0cyMroinI0@public.gmane.org>
2013-12-04 14:28                                 ` Kishon Vijay Abraham I
2013-12-04 14:28                                   ` Kishon Vijay Abraham I
2013-12-04 14:28                                   ` Kishon Vijay Abraham I
2013-12-05  8:14                                   ` Vivek Gautam
2013-12-05  8:14                                     ` Vivek Gautam
2013-12-24 17:45                                     ` Kishon Vijay Abraham I
2013-12-24 17:45                                       ` Kishon Vijay Abraham I
2013-12-24 17:45                                       ` Kishon Vijay Abraham I
2013-12-30  9:43                                       ` Vivek Gautam
2013-12-30  9:43                                         ` Vivek Gautam
2014-01-07  9:49                                         ` Kishon Vijay Abraham I
2014-01-07  9:49                                           ` Kishon Vijay Abraham I
2014-01-07  9:49                                           ` Kishon Vijay Abraham I
2014-01-07 11:03                                           ` Vivek Gautam
2014-01-07 11:03                                             ` Vivek Gautam
2014-01-07 11:03                                             ` Vivek Gautam
2014-01-20 13:45                                             ` Vivek Gautam
2014-01-20 13:45                                               ` Vivek Gautam
2013-11-05 17:56             ` Vivek Gautam
2013-11-05 17:56               ` Vivek Gautam
2013-11-04 12:26     ` Tomasz Figa
2013-11-04 12:26       ` Tomasz Figa
2013-11-04 13:09       ` Kishon Vijay Abraham I [this message]
2013-11-04 13:09         ` Kishon Vijay Abraham I
2013-11-04 13:09         ` Kishon Vijay Abraham I
     [not found]       ` <CAFp+6iG5SAe5h0-RRsBuAhtWO_NBW6G=7jQeObd4Y2BQGaRHyA@mail.gmail.com>
2013-11-05  7:12         ` Vivek Gautam
2013-11-05  7:12           ` Vivek Gautam
2013-11-10 14:08   ` Tomasz Figa
2013-11-10 14:08     ` Tomasz Figa
2013-11-20  8:44     ` Vivek Gautam
2013-11-20  8:44       ` Vivek Gautam
2013-11-20  8:55       ` Vivek Gautam
2013-11-20  8:55         ` Vivek Gautam
2013-11-21 12:26   ` Yuvaraj Cd
2013-11-21 12:26     ` Yuvaraj Cd
2013-10-31  7:45 ` [PATCH 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy Vivek Gautam
2013-10-31  7:45   ` Vivek Gautam
2013-11-10 14:54   ` Tomasz Figa
2013-11-10 14:54     ` Tomasz Figa
2013-10-31  7:45 ` [PATCH 3/4] dt: exynos5420: Enable support for USB 3.0 PHY controller Vivek Gautam
2013-10-31  7:45   ` Vivek Gautam
2013-10-31  7:45 ` [PATCH 4/4] dt: exynos5420: Enable support for DWC3 controller Vivek Gautam
2013-10-31  7:45   ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52779C6C.1090603@ti.com \
    --to=kishon@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gautam.vivek@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=jwerner@chromium.org \
    --cc=k.debski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.