Re: [PATCH 2/3] scsi: improved eh timeout handler

[Hannes Reinecke <hare@suse.de>]

On 10/31/2013 04:49 PM, Christoph Hellwig wrote:
> Looks reasonable to me, but a few minor nitpicks:
> 
>> +	spin_lock_irqsave(sdev->host->host_lock, flags);
>> +	if (scsi_host_eh_past_deadline(sdev->host)) {
> 
> I don't have the implementation of scsi_host_eh_past_deadline in my
> local tree, but do we really need the host lock for it?
> 
Yes. The eh_deadline variable might be set from an interrupt context
or from userland, so we need to protect access to it.

>> +int
>> +scsi_abort_command(struct scsi_cmnd *scmd)
> 
> Seems like this should be static and not exported in the current version
> of the code?
> 
Yep. Will be doing so.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html