* [PATCH] mtd: gpmi: Use devm_kzalloc()
@ 2013-11-05 2:07 Fabio Estevam
2013-11-05 2:49 ` Huang Shijie
2013-11-07 18:40 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-11-05 2:07 UTC (permalink / raw)
To: computersforpeace; +Cc: Fabio Estevam, b32955, linux-mtd
From: Fabio Estevam <fabio.estevam@freescale.com>
Using devm_kzalloc() can make the code simpler.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 7ac2280..4b6d802 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1732,7 +1732,7 @@ static int gpmi_nand_probe(struct platform_device *pdev)
return -ENODEV;
}
- this = kzalloc(sizeof(*this), GFP_KERNEL);
+ this = devm_kzalloc(&pdev->dev, sizeof(*this), GFP_KERNEL);
if (!this) {
pr_err("Failed to allocate per-device memory\n");
return -ENOMEM;
@@ -1762,7 +1762,6 @@ exit_nfc_init:
release_resources(this);
exit_acquire_resources:
dev_err(this->dev, "driver registration failed: %d\n", ret);
- kfree(this);
return ret;
}
@@ -1773,7 +1772,6 @@ static int gpmi_nand_remove(struct platform_device *pdev)
gpmi_nfc_exit(this);
release_resources(this);
- kfree(this);
return 0;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: gpmi: Use devm_kzalloc()
2013-11-05 2:07 [PATCH] mtd: gpmi: Use devm_kzalloc() Fabio Estevam
@ 2013-11-05 2:49 ` Huang Shijie
2013-11-07 18:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Huang Shijie @ 2013-11-05 2:49 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, computersforpeace, linux-mtd
于 2013年11月05日 10:07, Fabio Estevam 写道:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Using devm_kzalloc() can make the code simpler.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 7ac2280..4b6d802 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1732,7 +1732,7 @@ static int gpmi_nand_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - this = kzalloc(sizeof(*this), GFP_KERNEL);
> + this = devm_kzalloc(&pdev->dev, sizeof(*this), GFP_KERNEL);
> if (!this) {
> pr_err("Failed to allocate per-device memory\n");
> return -ENOMEM;
> @@ -1762,7 +1762,6 @@ exit_nfc_init:
> release_resources(this);
> exit_acquire_resources:
> dev_err(this->dev, "driver registration failed: %d\n", ret);
> - kfree(this);
>
> return ret;
> }
> @@ -1773,7 +1772,6 @@ static int gpmi_nand_remove(struct platform_device *pdev)
>
> gpmi_nfc_exit(this);
> release_resources(this);
> - kfree(this);
> return 0;
> }
>
thanks!
Acked-by: Huang Shijie <b32955@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: gpmi: Use devm_kzalloc()
2013-11-05 2:07 [PATCH] mtd: gpmi: Use devm_kzalloc() Fabio Estevam
2013-11-05 2:49 ` Huang Shijie
@ 2013-11-07 18:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2013-11-07 18:40 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, b32955, linux-mtd
On Tue, Nov 05, 2013 at 12:07:05AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Using devm_kzalloc() can make the code simpler.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Thanks, pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-07 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-05 2:07 [PATCH] mtd: gpmi: Use devm_kzalloc() Fabio Estevam
2013-11-05 2:49 ` Huang Shijie
2013-11-07 18:40 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.