From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Andrew Victor <linux@maxim.org.za>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] pinctrl: at91: copy define to driver
Date: Tue, 5 Nov 2013 10:52:44 +0100 [thread overview]
Message-ID: <5278BFEC.4070600@atmel.com> (raw)
In-Reply-To: <1383643814-14308-1-git-send-email-linus.walleij@linaro.org>
On 05/11/2013 10:30, Linus Walleij :
> The #define for the maximum number of GPIO blocks was retrieved
> into pinctrl-at91.c by implicit inclusion of <mach/gpio.h>
> from <linux/gpio.h> creating a dependency on machine-local
> <mach/gpio.h>. Break the depenency by copying this single
> define into the driver.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Yes, that seems reasonable.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> This will be applied directly to the pinctrl tree unless there
> are specific protests.
> ---
> drivers/pinctrl/pinctrl-at91.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index f350fd2e170e..0dfb8c7b58df 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -33,6 +33,7 @@
>
> #include "core.h"
>
> +#define MAX_GPIO_BANKS 5
> #define MAX_NB_GPIO_PER_BANK 32
>
> struct at91_pinctrl_mux_ops;
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] pinctrl: at91: copy define to driver
Date: Tue, 5 Nov 2013 10:52:44 +0100 [thread overview]
Message-ID: <5278BFEC.4070600@atmel.com> (raw)
In-Reply-To: <1383643814-14308-1-git-send-email-linus.walleij@linaro.org>
On 05/11/2013 10:30, Linus Walleij :
> The #define for the maximum number of GPIO blocks was retrieved
> into pinctrl-at91.c by implicit inclusion of <mach/gpio.h>
> from <linux/gpio.h> creating a dependency on machine-local
> <mach/gpio.h>. Break the depenency by copying this single
> define into the driver.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Yes, that seems reasonable.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> This will be applied directly to the pinctrl tree unless there
> are specific protests.
> ---
> drivers/pinctrl/pinctrl-at91.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index f350fd2e170e..0dfb8c7b58df 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -33,6 +33,7 @@
>
> #include "core.h"
>
> +#define MAX_GPIO_BANKS 5
> #define MAX_NB_GPIO_PER_BANK 32
>
> struct at91_pinctrl_mux_ops;
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-11-05 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 9:30 [PATCH 3/4] pinctrl: at91: copy define to driver Linus Walleij
2013-11-05 9:30 ` Linus Walleij
2013-11-05 9:52 ` Nicolas Ferre [this message]
2013-11-05 9:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5278BFEC.4070600@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.