From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>
Cc: "durgadoss.r-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<durgadoss.r-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jinyoung Park <jinyoungp-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] thermal: Fix binding problem when there is thermal zone params
Date: Wed, 6 Nov 2013 14:04:06 +0800 [thread overview]
Message-ID: <5279DBD6.9090708@nvidia.com> (raw)
In-Reply-To: <1383715752.2073.11.camel@rzhang1-mobl4>
On 11/06/2013 01:29 PM, Zhang Rui wrote:
> On Fri, 2013-10-18 at 18:03 +0800, Wei Ni wrote:
>> @@ -247,7 +247,7 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
>> if (!pos->tzp && !pos->ops->bind)
>> continue;
>>
>> - if (!pos->tzp && pos->ops->bind) {
>> + if (pos->ops->bind) {
>> ret = pos->ops->bind(pos, cdev);
>> if (ret)
>> print_bind_err_msg(pos, cdev, ret);
> IMO, we should also add
> + continue;
> after binding with pos->ops->bind(), to void binding via pos->tzp->tbp
> again, no?
Oh, yes, you are right. I will add it.
>
> thanks,
> rui
>> @@ -282,8 +282,8 @@ static void bind_tz(struct thermal_zone_device *tz)
>>
>> mutex_lock(&thermal_list_lock);
>>
>> - /* If there is no platform data, try to use ops->bind */
>> - if (!tzp && tz->ops->bind) {
>> + /* If there is ops->bind, try to use ops->bind */
>> + if (tz->ops->bind) {
>> list_for_each_entry(pos, &thermal_cdev_list, node) {
>> ret = tz->ops->bind(tz, pos);
>> if (ret)
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Ni <wni@nvidia.com>
To: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>
Cc: "durgadoss.r@intel.com" <durgadoss.r@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Jinyoung Park <jinyoungp@nvidia.com>
Subject: Re: [PATCH] thermal: Fix binding problem when there is thermal zone params
Date: Wed, 6 Nov 2013 14:04:06 +0800 [thread overview]
Message-ID: <5279DBD6.9090708@nvidia.com> (raw)
In-Reply-To: <1383715752.2073.11.camel@rzhang1-mobl4>
On 11/06/2013 01:29 PM, Zhang Rui wrote:
> On Fri, 2013-10-18 at 18:03 +0800, Wei Ni wrote:
>> @@ -247,7 +247,7 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
>> if (!pos->tzp && !pos->ops->bind)
>> continue;
>>
>> - if (!pos->tzp && pos->ops->bind) {
>> + if (pos->ops->bind) {
>> ret = pos->ops->bind(pos, cdev);
>> if (ret)
>> print_bind_err_msg(pos, cdev, ret);
> IMO, we should also add
> + continue;
> after binding with pos->ops->bind(), to void binding via pos->tzp->tbp
> again, no?
Oh, yes, you are right. I will add it.
>
> thanks,
> rui
>> @@ -282,8 +282,8 @@ static void bind_tz(struct thermal_zone_device *tz)
>>
>> mutex_lock(&thermal_list_lock);
>>
>> - /* If there is no platform data, try to use ops->bind */
>> - if (!tzp && tz->ops->bind) {
>> + /* If there is ops->bind, try to use ops->bind */
>> + if (tz->ops->bind) {
>> list_for_each_entry(pos, &thermal_cdev_list, node) {
>> ret = tz->ops->bind(tz, pos);
>> if (ret)
>
>
next prev parent reply other threads:[~2013-11-06 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 10:03 [PATCH] thermal: Fix binding problem when there is thermal zone params Wei Ni
2013-10-18 10:03 ` Wei Ni
2013-11-06 5:29 ` Zhang Rui
2013-11-06 6:04 ` Wei Ni [this message]
2013-11-06 6:04 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5279DBD6.9090708@nvidia.com \
--to=wni-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=durgadoss.r-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=eduardo.valentin-l0cyMroinI0@public.gmane.org \
--cc=jinyoungp-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.