Re: [RFC PATCH v3] dm mpath: add a queue_if_no_path timeout

[Hannes Reinecke <hare@suse.de>]

On 11/05/2013 05:02 PM, Frank Mayhar wrote:
> This is the patch submitted by Jun'ichi Nomura, originally based on
> Mike's patch with some small changes by me.  Jun'ichi's description
> follows, along with my changes:
> 
> On Tue, 2013-11-05 at 07:18 -0800, Frank Mayhar wrote:
>> On Fri, 2013-11-01 at 04:17 +0000, Junichi Nomura wrote:
>>> I slightly modified the patch:
>>>   - fixed the timeout handler to correctly find
>>>     clone request and "struct multipath"
>>>   - the timeout handler just disables "queue_if_no_path"
>>>     instead of killing the request directly
>>>   - "dmsetup status" to show the parameter
>>>   - changed an interface between dm core and target
>>>   - added some debugging printk (you can remove them)
>>> and checked the timeout occurs, at least.
>>>
>>> I'm not sure if this feature is good or not though.
>>> (The timer behavior is not intuitive, I think)
>> Thanks!  I integrated your new patch and tested it.  Sure enough, it
>> seems to work.  I've made a few tweaks (added a module tunable and
>> support for setting the timer in multipath_message(), removed your debug
>> printks) and will submit the modified patch for discussion shortly.
> 
> Comments?
> 
Yeah. Seems to be my eternal fate; initiating fixes and not getting
mentioned at all.
Sigh.

I dimly remember having sent the original patch for the blk timeout
function ... hence a short notice would've been nice.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)