From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Daniel Kiper <daniel.kiper@oracle.com>,
Keir Fraser <keir@xen.org>,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] kexec: don't disable interrupts when acquiring load/unload lock
Date: Wed, 6 Nov 2013 15:09:55 +0000 [thread overview]
Message-ID: <527A5BC3.3030905@citrix.com> (raw)
In-Reply-To: <527A5DA60200007800100267@nat28.tlf.novell.com>
On 06/11/13 14:17, Jan Beulich wrote:
>>>> On 06.11.13 at 14:20, David Vrabel <david.vrabel@citrix.com> wrote:
>> On 06/11/13 12:22, Jan Beulich wrote:
>>> This doesn't appear to have served any purpose other than causing
>>> map_pages_to_xen() to be (incorrectly) invoked with interrupts
>>> disabled. In particular, serialization against actual kexec-ing is done
>>> without this lock being involved. Clarify the scope of the lock at once
>>> by making it local to do_kexec_op_internal().
>>>
>>> Once at it, also drop a pointless initializer.
>>
>> I've already dropped the irqsave from this lock in my kexec series and
>> can fold the other part in as well (which would now be in
>> kexec_swap_images()).
>
> That would generally be fine, but I'd like to get this fixed no matter
> whether your patches make 4.4.
Sure. I was only asking if you could wait a few days.
David
next prev parent reply other threads:[~2013-11-06 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 12:22 [PATCH] kexec: don't disable interrupts when acquiring load/unload lock Jan Beulich
2013-11-06 13:12 ` Andrew Cooper
2013-11-06 13:20 ` David Vrabel
2013-11-06 14:17 ` Jan Beulich
2013-11-06 15:09 ` David Vrabel [this message]
2013-11-06 15:16 ` Jan Beulich
2013-11-06 14:53 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527A5BC3.3030905@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=daniel.kiper@oracle.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.