[U-Boot] [RFC][PATCH 0/5] SATA support for OMAP5 uevm

From: Roger Quadros <rogerq@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH 0/5] SATA support for OMAP5 uevm
Date: Thu, 7 Nov 2013 12:44:54 +0200	[thread overview]
Message-ID: <527B6F26.4020604@ti.com> (raw)
In-Reply-To: <CAFqH_51AoEpSU0zhpAOx6-ZJ=kcNyLr3gdX+3QqAs_QSsrUDMg@mail.gmail.com>

+Aneesh.

Hi Enric,

On 11/07/2013 10:52 AM, Enric Balletbo Serra wrote:
> Hi Roger,
> 
> Thanks for the patches!
> 
> 2013/11/6 Roger Quadros <rogerq@ti.com>:
>> Hi,
>>
>> This series adds SATA support for OMAP5 uevm board.
>>
>> This is an RFC patchset for review only. Patches are based
>> on v2013.10.
>>
>> cheers,
>> -roger
>>
>> ---
>> Roger Quadros (5):
>>   ahci: Error out with message on malloc() failure
>>   ARM: OMAP5: Add Pipe3 PHY driver
>>   ARM: OMAP5: Add PRCM and Control information for SATA
>>   ARM: OMAP5: Add SATA platform glue
>>   ARM: omap5_uevm: Add SATA support
>>
>>  arch/arm/cpu/armv7/omap-common/Makefile    |   7 +
>>  arch/arm/cpu/armv7/omap-common/pipe3-phy.c | 233 +++++++++++++++++++++++++++++
>>  arch/arm/cpu/armv7/omap-common/pipe3-phy.h |  36 +++++
>>  arch/arm/cpu/armv7/omap-common/sata.c      |  78 ++++++++++
>>  arch/arm/cpu/armv7/omap5/prcm-regs.c       |   5 +
>>  arch/arm/include/asm/arch-omap5/clock.h    |   3 +
>>  arch/arm/include/asm/arch-omap5/omap.h     |   3 +
>>  arch/arm/include/asm/arch-omap5/sata.h     |  48 ++++++
>>  arch/arm/include/asm/omap_common.h         |   3 +
>>  board/ti/omap5_uevm/evm.c                  |   7 +
>>  drivers/block/ahci.c                       |  16 +-
>>  include/configs/omap5_uevm.h               |  10 ++
>>  12 files changed, 447 insertions(+), 2 deletions(-)
>>  create mode 100644 arch/arm/cpu/armv7/omap-common/pipe3-phy.c
>>  create mode 100644 arch/arm/cpu/armv7/omap-common/pipe3-phy.h
>>  create mode 100644 arch/arm/cpu/armv7/omap-common/sata.c
>>  create mode 100644 arch/arm/include/asm/arch-omap5/sata.h
>>
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
> 
> I applied your patches and worked perfectly, however I've two small issues.
> 
> The first issue is that I see the following error:
> 
>     scanning bus for devices...
>     ERROR: v7_dcache_inval_range - start address is not aligned - 0xfee48618
>     ERROR: v7_dcache_inval_range - stop address is not aligned - 0xfee48818

I'm seeing this too. Not sure how to fix it.
Aneesh, any pointers?

> 
> The second issue, and I'm not sure if the problem should be solved at
> u-boot level, is that I'm not able to access to the SATA disk at
> kernel level. I meant, if I boot to the system with latest stable
> u-boot the kernel recognizes the SATA disk and I'm able to mount, read
> and write to the disk. If I boot using u-boot with your patches
> applied the kernel doesn't recognizes the SATA disk and doesn't work.
> In that case the kernel reports the following error:
> 
>      ata1: COMRESET failed (errno=-16)
> 
> Note that the kernel version that I'm using is 3.8.13 from git.ti.com.

There is a known issue with the SATA DPLL

"1.52 SATA Lockup After SATA DPLL Unlock/Relock - Errata ID: i783"

So, we'll need to do something in the kernel before these patches get
into u-boot.

I'll try to come up with a solution soon. Something on the lines of not
re-initializing the SATA DPLL if it is already locked.

cheers,
-roger