All of lore.kernel.org
 help / color / mirror / Atom feed
From: james.hogan@imgtec.com (James Hogan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] seccomp: not compatible with ARM OABI
Date: Thu, 7 Nov 2013 10:59:59 +0000	[thread overview]
Message-ID: <527B72AF.50002@imgtec.com> (raw)
In-Reply-To: <20131106233117.GA24545@www.outflux.net>

Hi,

On 06/11/13 23:31, Kees Cook wrote:
> diff --git a/arch/Kconfig b/arch/Kconfig
> index af2cc6eabcc7..6eaca7d92399 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER
>  
>  config SECCOMP_FILTER
>  	def_bool y
> -	depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET
> +	depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT

Isn't this the whole point of HAVE_ARCH_SECCOMP_FILTER?

Just change the select in arch/arm/Kconfig to this:

	select HAVE_ARCH_SECCOMP_FILTER if !OABI_COMPAT

Cheers
James

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Kees Cook <keescook@chromium.org>
Cc: <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Eric Paris <eparis@redhat.com>,
	<libseccomp-discuss@lists.sourceforge.net>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Will Drewry <wad@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] seccomp: not compatible with ARM OABI
Date: Thu, 7 Nov 2013 10:59:59 +0000	[thread overview]
Message-ID: <527B72AF.50002@imgtec.com> (raw)
In-Reply-To: <20131106233117.GA24545@www.outflux.net>

Hi,

On 06/11/13 23:31, Kees Cook wrote:
> diff --git a/arch/Kconfig b/arch/Kconfig
> index af2cc6eabcc7..6eaca7d92399 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER
>  
>  config SECCOMP_FILTER
>  	def_bool y
> -	depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET
> +	depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT

Isn't this the whole point of HAVE_ARCH_SECCOMP_FILTER?

Just change the select in arch/arm/Kconfig to this:

	select HAVE_ARCH_SECCOMP_FILTER if !OABI_COMPAT

Cheers
James


  parent reply	other threads:[~2013-11-07 10:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 23:31 [PATCH] seccomp: not compatible with ARM OABI Kees Cook
2013-11-06 23:31 ` Kees Cook
2013-11-07  3:26 ` Will Drewry
2013-11-07  3:26   ` Will Drewry
2013-11-07 10:59 ` James Hogan [this message]
2013-11-07 10:59   ` James Hogan
2013-11-07 17:26   ` Kees Cook
2013-11-07 17:26     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527B72AF.50002@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.