From: Richard Henderson <rth@twiddle.net>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.8 61/61] target-i386: Deconstruct thecpu_T arrayy
Date: Fri, 08 Nov 2013 06:38:02 +1000 [thread overview]
Message-ID: <527BFA2A.7040301@twiddle.net> (raw)
In-Reply-To: <p14n7o7aaa.fsf@linaro.org>
On 11/07/2013 08:53 PM, Alex Bennée wrote:
>
> rth@twiddle.net writes:
>
>> All references to cpu_T are done with a constant index. It aids
>> readability to decompose the array into two scalar variables.
> <snip>
>
> I'm not necessarily disagreeing with the readability argument but does
> this make any difference to the eventual code generated?
>
None at all.
r~
prev parent reply other threads:[~2013-11-07 20:38 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 1:04 [Qemu-devel] [PATCH for-1.8 00/61] target-i386 improvements Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 01/61] exec: Delay CPU_LOG_TB_CPU until we actually execute a TB Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 02/61] target-i386: Push DisasContext into load/store helpers Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 03/61] target-i386: Stop encoding DisasContext.mem_index Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 04/61] target-i386: Use new tcg_gen_qemu_ld_* helpers Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 05/61] target-i386: Use new tcg_gen_qemu_st_* helpers Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 06/61] target-i386: Replace OT_* constants with MO_* constants Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 07/61] target-i386: Remove gen_op_ld_T0_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 08/61] target-i386: Remove gen_op_ldu_T0_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 09/61] target-i386: Remove gen_op_ld_T1_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 10/61] target-i386: Remove gen_op_lds_T0_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 11/61] target-i386: Introduce gen_op_st_rm_T0_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 12/61] target-i386: Remove gen_op_st_T0_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 13/61] target-i386: Remove gen_op_st_T1_A0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 14/61] target-i386: Fix typo in gen_push_T1 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 15/61] target-i386: Tidy mov[sz][bw] Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 16/61] target-i386: Tidy movsl Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 17/61] target-i386: Remove unused arguments to gen_lea_modrm Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 18/61] target-i386: Use MO_BE for movbe Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 19/61] target-i386: Tidy gen_op_mov_TN_reg+tcg_gen_trunc_tl_i32 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 20/61] target-i386: Tidy load + truncate Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 21/61] target-i386: Tidy extend + store Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 22/61] target-i386: Tidy extend + move Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 23/61] target-i386: Remove gen_op_movl_T0_0 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 24/61] target-i386: Remove gen_op_movl_T0_im* Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 25/61] " Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 26/61] target-i386: Remove gen_op_mov*_A0_im Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 27/61] target-i386: Remove gen_movtl_T*_im Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 28/61] target-i386: Remove gen_op_andl_T0_ffff Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 29/61] target-i386: Remove gen_op_andl_T0_im Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 30/61] target-i386: Remove gen_op_movl_T0_T1 Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 31/61] target-i386: Remove gen_op_andl_A0_ffff Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 32/61] target-i386: Use TCGMemOp for 'ot' variables Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 33/61] target-i386: Change gen_op_add_reg_* size parameter to TCGMemOp Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 34/61] target-i386: Change gen_op_j*z_ecx " Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 35/61] target-i386: Change aflag " Richard Henderson
2013-11-07 1:04 ` [Qemu-devel] [PATCH for-1.8 36/61] target-i386: Change gen_op_mov_reg_A0 size parameter " Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 37/61] target-i386: Change dflag " Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 38/61] target-i386: Fix addr32 prefix in gen_lea_modrm Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 39/61] target-i386: Tidy addr16 code " Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 40/61] target-i386: Combine gen_push_T* into gen_push_v Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 41/61] target_i386: Clean up gen_pop_T0 Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 42/61] target-i386: Create gen_lea_v_seg Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 43/61] target-i386: Use gen_lea_v_seg in gen_lea_modrm Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 44/61] target-i386: Use gen_lea_v_seg in stack subroutines Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 45/61] target-i386: Tidy cpu_regs initialization Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 46/61] target-i386: Access segs via TCG registers Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 47/61] target-i386: Use gen_lea_v_seg in pusha/popa Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 48/61] target-i386: Rewrite gen_enter inline Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 49/61] target-i386: Introduce mo_stacksize Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 50/61] target-i386: Rewrite leave Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 51/61] target-i386: Remove gen_op_mov_reg_T0 Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 52/61] target-i386: Remove gen_op_mov_reg_T1 Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 53/61] target-i386: Remove gen_op_addl_T0_T1 Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 54/61] target-i386: Remove gen_op_mov_TN_reg Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 55/61] target-i386: Remove gen_op_mov_reg_A0 Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 56/61] target-i386: Remove gen_op_movl_A0_reg Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 57/61] target-i386: Tidy gen_add_A0_im Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 58/61] target-i386: Tidy some size computation Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 59/61] target-i386: Rename gen_op_jmp_T0 to gen_op_jmp_v Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 60/61] target-i386: Tidy ljmp Richard Henderson
2013-11-07 1:05 ` [Qemu-devel] [PATCH for-1.8 61/61] target-i386: Deconstruct the cpu_T array Richard Henderson
2013-11-07 10:53 ` [Qemu-devel] [PATCH for-1.8 61/61] target-i386: Deconstruct thecpu_T arrayy Alex Bennée
2013-11-07 20:38 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527BFA2A.7040301@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.