All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 9/9] ARM: add initial support for Marvell Berlin SoCs
Date: Thu, 07 Nov 2013 22:22:35 +0100	[thread overview]
Message-ID: <527C049B.4030608@gmail.com> (raw)
In-Reply-To: <201311071720.47489.arnd@arndb.de>

On 11/07/2013 05:20 PM, Arnd Bergmann wrote:
> On Thursday 07 November 2013, Sebastian Hesselbarth wrote:
>> Actually, IIRC smp_twd does not compile without SMP set, so the above
>> should at least be 'HAVE_ARM_TWD if SMP'. If you shrink MULTI_V7 down
>> to non-SMP cores, you can disable it and it will fail to compile.
>
> If there are UP-systems for which TWD is the best clocksource, we should
> probably fix the code to allow that configuration. IIRC there were already
> patches recently in this area, maybe it's already solved.

I just tried barebox bootloader to use TWD as timer on berlin2cd and it
perfectly works, i.e. with time related commands I can see the timer
register decreasing. So the timer is available on this UP SoC.

As said before, compiling linux without CONFIG_SMP but with
CONFIG_HAVE_ARM_TWD gives:

warning: (SOC_OMAP5 && ARCH_ROCKCHIP && ARCH_SHMOBILE_MULTI && 
MACH_BERLIN_BG2 && MACH_BERLIN_BG2CD) selects HAVE_ARM_TWD which has 
unmet direct dependencies (SMP)

and

arch/arm/kernel/smp_twd.c: In function 'twd_local_timer_of_register':
arch/arm/kernel/smp_twd.c:391: error: 'setup_max_cpus' undeclared (first 
use in this function)
arch/arm/kernel/smp_twd.c:391: error: (Each undeclared identifier is 
reported only once
arch/arm/kernel/smp_twd.c:391: error: for each function it appears in.)
make[1]: *** [arch/arm/kernel/smp_twd.o] Error 1

I haven't looked deeper into this, but I guess it will not be hard
to make ARM_TWD independent of SMP.

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jisheng Zhang <jszhang@marvell.com>,
	Russell King <linux@arm.linux.org.uk>,
	Kevin Hilman <khilman@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Olof Johansson <olof@lixom.net>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 9/9] ARM: add initial support for Marvell Berlin SoCs
Date: Thu, 07 Nov 2013 22:22:35 +0100	[thread overview]
Message-ID: <527C049B.4030608@gmail.com> (raw)
In-Reply-To: <201311071720.47489.arnd@arndb.de>

On 11/07/2013 05:20 PM, Arnd Bergmann wrote:
> On Thursday 07 November 2013, Sebastian Hesselbarth wrote:
>> Actually, IIRC smp_twd does not compile without SMP set, so the above
>> should at least be 'HAVE_ARM_TWD if SMP'. If you shrink MULTI_V7 down
>> to non-SMP cores, you can disable it and it will fail to compile.
>
> If there are UP-systems for which TWD is the best clocksource, we should
> probably fix the code to allow that configuration. IIRC there were already
> patches recently in this area, maybe it's already solved.

I just tried barebox bootloader to use TWD as timer on berlin2cd and it
perfectly works, i.e. with time related commands I can see the timer
register decreasing. So the timer is available on this UP SoC.

As said before, compiling linux without CONFIG_SMP but with
CONFIG_HAVE_ARM_TWD gives:

warning: (SOC_OMAP5 && ARCH_ROCKCHIP && ARCH_SHMOBILE_MULTI && 
MACH_BERLIN_BG2 && MACH_BERLIN_BG2CD) selects HAVE_ARM_TWD which has 
unmet direct dependencies (SMP)

and

arch/arm/kernel/smp_twd.c: In function 'twd_local_timer_of_register':
arch/arm/kernel/smp_twd.c:391: error: 'setup_max_cpus' undeclared (first 
use in this function)
arch/arm/kernel/smp_twd.c:391: error: (Each undeclared identifier is 
reported only once
arch/arm/kernel/smp_twd.c:391: error: for each function it appears in.)
make[1]: *** [arch/arm/kernel/smp_twd.o] Error 1

I haven't looked deeper into this, but I guess it will not be hard
to make ARM_TWD independent of SMP.

Sebastian


  reply	other threads:[~2013-11-07 21:22 UTC|newest]

Thread overview: 181+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 12:24 [PATCH 0/8] ARM: Initial support for Marvell Berlin SoCs Sebastian Hesselbarth
2013-10-08 12:24 ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 1/8] irqchip: add DesignWare APB ICTL interrupt controller Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-08 13:24   ` Mark Rutland
2013-10-08 13:24     ` Mark Rutland
2013-10-08 15:51     ` Sebastian Hesselbarth
2013-10-08 15:51       ` Sebastian Hesselbarth
2013-10-11  9:30   ` Jisheng Zhang
2013-10-11  9:30     ` Jisheng Zhang
2013-10-17  6:37   ` [PATCH v2 " Sebastian Hesselbarth
2013-10-17  6:37     ` Sebastian Hesselbarth
2013-10-25 21:30     ` Sebastian Hesselbarth
2013-10-25 21:30       ` Sebastian Hesselbarth
2013-10-25 21:30       ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 2/8] MAINTAINERS: add ARM Marvell Berlin SoC Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-08 13:57   ` Jason Cooper
2013-10-08 13:57     ` Jason Cooper
2013-10-08 12:24 ` [PATCH 3/8] ARM: l2x0: add Marvell Tauros3 compatible Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-08 13:41   ` Mark Rutland
2013-10-08 13:41     ` Mark Rutland
2013-10-08 13:41     ` Mark Rutland
2013-10-08 16:05     ` Sebastian Hesselbarth
2013-10-08 16:05       ` Sebastian Hesselbarth
2013-10-08 16:33       ` Gregory CLEMENT
2013-10-08 16:33         ` Gregory CLEMENT
2013-10-09  8:50         ` Mark Rutland
2013-10-09  8:50           ` Mark Rutland
2013-10-09  9:14           ` Gregory CLEMENT
2013-10-09  9:14             ` Gregory CLEMENT
2013-10-09 19:27           ` Sebastian Hesselbarth
2013-10-09 19:27             ` Sebastian Hesselbarth
2013-10-11  9:05             ` Lennert Buytenhek
2013-10-11  9:05               ` Lennert Buytenhek
2013-10-11  9:05               ` Lennert Buytenhek
2013-10-17  6:37   ` [PATCH v2 3/8] ARM: l2x0: add Marvell Tauros3 support Sebastian Hesselbarth
2013-10-17  6:37     ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 4/8] ARM: add Marvell Berlin SoC familiy to Marvell doc Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-14 23:09   ` Sebastian Hesselbarth
2013-10-14 23:09     ` Sebastian Hesselbarth
2013-10-15  3:10     ` Jisheng Zhang
2013-10-15  3:10       ` Jisheng Zhang
2013-10-15 17:09       ` Sebastian Hesselbarth
2013-10-15 17:09         ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 5/8] ARM: add Marvell Berlin and Armada 1500 to multi_v7_defconfig Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 6/8] ARM: add Marvell Berlin UART0 lowlevel debug Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 7/8] ARM: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-14 23:13   ` Sebastian Hesselbarth
2013-10-14 23:13     ` Sebastian Hesselbarth
2013-10-14 23:13     ` Sebastian Hesselbarth
2013-10-14 23:18     ` Sebastian Hesselbarth
2013-10-14 23:18       ` Sebastian Hesselbarth
2013-10-15  3:06     ` Jisheng Zhang
2013-10-15  3:06       ` Jisheng Zhang
2013-10-17  6:37   ` [PATCH v2 " Sebastian Hesselbarth
2013-10-17  6:37     ` Sebastian Hesselbarth
2013-10-08 12:24 ` [PATCH 8/8] ARM: add initial support for Marvell Berlin SoCs Sebastian Hesselbarth
2013-10-08 12:24   ` Sebastian Hesselbarth
2013-10-08 23:24   ` Dinh Nguyen
2013-10-08 23:24     ` Dinh Nguyen
2013-10-09  7:08     ` Sebastian Hesselbarth
2013-10-09  7:08       ` Sebastian Hesselbarth
2013-10-09  3:20   ` Jisheng Zhang
2013-10-09  3:20     ` Jisheng Zhang
2013-10-09  7:20     ` Sebastian Hesselbarth
2013-10-09  7:20       ` Sebastian Hesselbarth
2013-10-09  9:24     ` Gregory CLEMENT
2013-10-09  9:24       ` Gregory CLEMENT
2013-10-17  6:37   ` [PATCH v2 " Sebastian Hesselbarth
2013-10-17  6:37     ` Sebastian Hesselbarth
2013-11-05 14:28 ` [PATCH v3 0/9] ARM: Initial " Sebastian Hesselbarth
2013-11-05 14:28   ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 1/9] irqchip: add DesignWare APB ICTL interrupt controller Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-06 11:34     ` Thomas Gleixner
2013-11-06 11:34       ` Thomas Gleixner
2013-11-06 11:34       ` Thomas Gleixner
2013-11-05 14:28   ` [PATCH v3 2/9] MAINTAINERS: add ARM Marvell Berlin SoC Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 3/9] ARM: l2x0: add Marvell Tauros3 support Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 4/9] ARM: add Marvell Berlin SoC familiy to Marvell doc Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-07  5:56     ` Jisheng Zhang
2013-11-07  5:56       ` Jisheng Zhang
2013-11-07 10:12       ` Sebastian Hesselbarth
2013-11-07 10:12         ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 5/9] ARM: add Marvell Berlin SoCs to multi_v7_defconfig Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 6/9] ARM: add Marvell Berlin UART0 lowlevel debug Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 7/9] ARM: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-08 16:13     ` Kumar Gala
2013-11-08 16:13       ` Kumar Gala
2013-11-08 16:57       ` Jason Cooper
2013-11-08 16:57         ` Jason Cooper
2013-11-08 18:06         ` Kumar Gala
2013-11-08 18:06           ` Kumar Gala
2013-11-08 18:24           ` Jason Cooper
2013-11-08 18:24             ` Jason Cooper
2013-11-08 19:14             ` Olof Johansson
2013-11-08 19:14               ` Olof Johansson
2013-11-08 19:14               ` Olof Johansson
2013-11-08 19:17               ` Sebastian Hesselbarth
2013-11-08 19:17                 ` Sebastian Hesselbarth
2013-11-08 19:19                 ` Olof Johansson
2013-11-08 19:19                   ` Olof Johansson
2013-11-08 19:30               ` Jason Cooper
2013-11-08 19:30                 ` Jason Cooper
2013-11-08 20:10                 ` Olof Johansson
2013-11-08 20:10                   ` Olof Johansson
2013-11-08 20:29                   ` Jason Cooper
2013-11-08 20:29                     ` Jason Cooper
2013-11-08 19:15             ` Sebastian Hesselbarth
2013-11-08 19:15               ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 8/9] ARM: add Armada 1500-mini and Chromecast " Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-07  5:48     ` Jisheng Zhang
2013-11-07  5:48       ` Jisheng Zhang
2013-11-07 10:12       ` Sebastian Hesselbarth
2013-11-07 10:12         ` Sebastian Hesselbarth
2013-11-05 14:28   ` [PATCH v3 9/9] ARM: add initial support for Marvell Berlin SoCs Sebastian Hesselbarth
2013-11-05 14:28     ` Sebastian Hesselbarth
2013-11-07  5:40     ` Jisheng Zhang
2013-11-07  5:40       ` Jisheng Zhang
2013-11-07  7:01       ` Jisheng Zhang
2013-11-07  7:01         ` Jisheng Zhang
2013-11-07 10:12       ` Sebastian Hesselbarth
2013-11-07 10:12         ` Sebastian Hesselbarth
2013-11-07 16:20         ` Arnd Bergmann
2013-11-07 16:20           ` Arnd Bergmann
2013-11-07 21:22           ` Sebastian Hesselbarth [this message]
2013-11-07 21:22             ` Sebastian Hesselbarth
2013-11-07 22:11             ` Arnd Bergmann
2013-11-07 22:11               ` Arnd Bergmann
2013-11-08  0:58             ` Jisheng Zhang
2013-11-08  0:58               ` Jisheng Zhang
2013-11-08  8:54               ` Sebastian Hesselbarth
2013-11-08  8:54                 ` Sebastian Hesselbarth
2013-12-08 14:13   ` [PATCH v4 0/9] ARM: Initial " Sebastian Hesselbarth
2013-12-08 14:13     ` Sebastian Hesselbarth
2013-12-08 14:13     ` [PATCH v4 1/9] irqchip: add DesignWare APB ICTL interrupt controller Sebastian Hesselbarth
2013-12-08 14:13       ` Sebastian Hesselbarth
2013-12-08 14:13     ` [PATCH v4 2/9] MAINTAINERS: add ARM Marvell Berlin SoC Sebastian Hesselbarth
2013-12-08 14:13       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 3/9] ARM: l2x0: add Marvell Tauros3 support Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 4/9] ARM: add Marvell Berlin SoC familiy to Marvell doc Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 5/9] ARM: add Marvell Berlin SoCs to multi_v7_defconfig Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 6/9] ARM: add Marvell Berlin UART0 lowlevel debug Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 7/9] ARM: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 8/9] ARM: add Armada 1500-mini and Chromecast " Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-08 14:14     ` [PATCH v4 9/9] ARM: add initial support for Marvell Berlin SoCs Sebastian Hesselbarth
2013-12-08 14:14       ` Sebastian Hesselbarth
2013-12-10  1:40     ` [PATCH v4 0/9] ARM: Initial " Olof Johansson
2013-12-10  1:40       ` Olof Johansson
2013-12-10  1:57       ` Sebastian Hesselbarth
2013-12-10  1:57         ` Sebastian Hesselbarth
2013-12-10 19:16         ` Olof Johansson
2013-12-10 19:16           ` Olof Johansson
2013-12-10 19:33           ` Arnd Bergmann
2013-12-10 19:33             ` Arnd Bergmann
2013-12-10 19:38             ` Olof Johansson
2013-12-10 19:38               ` Olof Johansson
2013-12-10 19:38               ` Olof Johansson
2013-12-10 20:02               ` Sebastian Hesselbarth
2013-12-10 20:02                 ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527C049B.4030608@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.