Re: [Xen-devel] [PATCH 3/9] kexec: add infrastructure for handling kexec images

[Don Slutz <dslutz@verizon.com>]

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

Sigh, my build just stopped.

kimage.c: In function 'kimage_crash_alloc':
kimage.c:222:9: error: unused variable 'result' [-Werror=unused-variable]
cc1: all warnings being treated as errors

A late change from v9 to v10 missed the removal of this variable.

Here is what I did to fix:

 From 09587856fa36ae38a500e218979f7111cb4546f4 Mon Sep 17 00:00:00 2001
From: Don Slutz <dslutz@verizon.com>
Date: Thu, 7 Nov 2013 18:46:23 -0500
Subject: [PATCH] kexec: remove result.

kimage.c: In function 'kimage_crash_alloc':
kimage.c:222:9: error: unused variable 'result' [-Werror=unused-variable]
cc1: all warnings being treated as errors

Signed-off-by: Don Slutz <dslutz@verizon.com>
---
  xen/common/kimage.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/xen/common/kimage.c b/xen/common/kimage.c
index 10fb785..5c3e3b3 100644
--- a/xen/common/kimage.c
+++ b/xen/common/kimage.c
@@ -219,7 +219,6 @@ static int kimage_crash_alloc(struct kexec_image **rimage, p
addr_t entry,
                                xen_kexec_segment_t *segments)
  {
      unsigned long i;
-    int result;

      /* Verify we have a valid entry point */
      if ( (entry < kexec_crash_area.start)
-- 
1.7.1

     -Don Slutz

On 11/07/13 15:40, Don Slutz wrote:
> For what it is worth.
>
> Reviewed-by: Don Slutz <dslutz@verizon.com>
>     -Don Slutz
>
> On 11/06/13 09:49, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Add the code needed to handle and load kexec images into Xen memory or
>> into the crash region.  This is needed for the new KEXEC_CMD_load and
>> KEXEC_CMD_unload hypercall sub-ops.
>>

[...]



[-- Attachment #2: 0001-kexec-remove-result.patch --]
[-- Type: text/x-patch, Size: 914 bytes --]

From 09587856fa36ae38a500e218979f7111cb4546f4 Mon Sep 17 00:00:00 2001
From: Don Slutz <dslutz@verizon.com>
Date: Thu, 7 Nov 2013 18:46:23 -0500
Subject: [PATCH] kexec: remove result.

kimage.c: In function 'kimage_crash_alloc':
kimage.c:222:9: error: unused variable 'result' [-Werror=unused-variable]
cc1: all warnings being treated as errors

Signed-off-by: Don Slutz <dslutz@verizon.com>
---
 xen/common/kimage.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/xen/common/kimage.c b/xen/common/kimage.c
index 10fb785..5c3e3b3 100644
--- a/xen/common/kimage.c
+++ b/xen/common/kimage.c
@@ -219,7 +219,6 @@ static int kimage_crash_alloc(struct kexec_image **rimage, paddr_t entry,
                               xen_kexec_segment_t *segments)
 {
     unsigned long i;
-    int result;
 
     /* Verify we have a valid entry point */
     if ( (entry < kexec_crash_area.start)
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec