From: Don Slutz <dslutz@verizon.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Don Slutz <Don@CloudSwitch.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Don Slutz <dslutz@verizon.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 04/12] xenctx: Add stack address to dump, switch to 16 bytes per line.
Date: Thu, 7 Nov 2013 19:13:37 -0500 [thread overview]
Message-ID: <527C2CB1.2030508@terremark.com> (raw)
In-Reply-To: <1383828377.32399.28.camel@kazak.uk.xensource.com>
On 11/07/13 07:46, Ian Campbell wrote:
> On Thu, 2013-11-07 at 08:12 +0000, Jan Beulich wrote:
>>>>> On 06.11.13 at 21:08, Don Slutz <dslutz@verizon.com> wrote:
>> Again - why?
> Having the stack address there can make it easier to locate a word
> referenced by a register for example, without error prone counting. In
> general many of the changelogs in this series could do with a second
> sentence in them after the title giving some rationale so we don't have
> to guess.
>
>> This makes it just two entries per line for a 64-bit
>> guest. Pretty little I would say.
> Agreed.
>
> I expect that along with the previous patch lines would now be over 80
> columns for sure. If that's the case then either the ascii or the
> address (or both) needs to be optional IMHO.
>
>> Jan
>>
I am happy to make it a command line option.
-Don Slutz
next prev parent reply other threads:[~2013-11-08 0:18 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:08 [PATCH v2 00/12] xenctx: Many changes Don Slutz
2013-11-06 20:08 ` [PATCH v2 01/12] xenctx: Clean up stack trace when hypercall_page not in symbol table Don Slutz
2013-11-07 8:07 ` Jan Beulich
2013-11-07 8:22 ` Ian Campbell
2013-11-07 8:47 ` Jan Beulich
2013-11-07 12:36 ` Ian Campbell
2013-11-07 13:28 ` Don Slutz
2013-11-07 12:38 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 02/12] xenctx: Add -2 (--two-pages) option to switch stack size to 8KiB Don Slutz
2013-11-07 8:04 ` Jan Beulich
2013-11-07 12:40 ` Ian Campbell
2013-11-07 15:24 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 03/12] xenctx: Output ascii version of stack also Don Slutz
2013-11-07 8:09 ` Jan Beulich
2013-11-07 12:43 ` Ian Campbell
2013-11-07 13:17 ` Jan Beulich
2013-11-07 13:21 ` Jan Beulich
2013-11-08 0:12 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 04/12] xenctx: Add stack address to dump, switch to 16 bytes per line Don Slutz
2013-11-07 8:12 ` Jan Beulich
2013-11-07 12:46 ` Ian Campbell
2013-11-08 0:13 ` Don Slutz [this message]
2013-11-06 20:08 ` [PATCH v2 05/12] xenctx: Change print_symbol to do the space before Don Slutz
2013-11-07 8:13 ` Jan Beulich
2013-11-07 12:47 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 06/12] xenctx: More info on failed to map page Don Slutz
2013-11-07 12:48 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 07/12] xenctx: Add stack addr to call trace Don Slutz
2013-11-07 12:50 ` Ian Campbell
2013-11-07 14:34 ` Don Slutz
2013-11-07 14:44 ` Ian Campbell
2013-11-07 15:06 ` Don Slutz
2013-11-07 16:03 ` Ian Campbell
2013-11-07 18:13 ` Don Slutz
2013-11-08 10:15 ` Ian Campbell
2013-11-06 20:08 ` [PATCH v2 08/12] xenctx: Add -d <daddr> option to dump memory at daddr as a stack Don Slutz
2013-11-07 8:22 ` Jan Beulich
2013-11-08 0:21 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 09/12] xenctx: Add -m <maddr> option to dump memory at maddr Don Slutz
2013-11-07 8:25 ` Jan Beulich
2013-11-08 0:24 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 10/12] xenctx: change is_kernel_text() into is_kernel_addr() Don Slutz
2013-11-07 8:35 ` Jan Beulich
2013-11-08 0:51 ` Don Slutz
2013-11-08 8:40 ` Jan Beulich
2013-11-08 9:50 ` Ian Campbell
2013-11-08 13:50 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 11/12] xenctx: Dump registers via hvm info if available Don Slutz
2013-11-06 20:35 ` Andrew Cooper
2013-11-07 18:56 ` Don Slutz
2013-11-08 10:13 ` Ian Campbell
2013-11-08 10:29 ` Andrew Cooper
2013-11-08 10:32 ` Ian Campbell
2013-11-07 8:38 ` Jan Beulich
2013-11-07 21:19 ` Don Slutz
2013-11-06 20:08 ` [PATCH v2 12/12] xenctx: Add optional fCPU Don Slutz
2013-11-07 8:40 ` Jan Beulich
2013-11-07 12:53 ` Ian Campbell
2013-11-07 21:24 ` Don Slutz
2013-11-08 11:29 ` [PATCH v2 00/12] xenctx: Many changes George Dunlap
2013-11-08 12:54 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527C2CB1.2030508@terremark.com \
--to=dslutz@verizon.com \
--cc=Don@CloudSwitch.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.