Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On 11/07/2013 08:26 PM, Fam Zheng wrote:
> If backing file doesn't exist, the error message is confusing and
> misleading:
> 
>     $ qemu /tmp/a.qcow2
>     qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
>     such file or directory
> 

> This is not intuitive. It's better to have the missing file's name in
> the error message. With this patch:
> 
>     $ qemu-io -c 'read 0 512' /tmp/a.qcow2
>     qemu-io: can't open device /tmp/a.qcow2: Could not open backing
>     file: Could not open '/stor/vm/arch.raw': No such file or directory
>     no file open, try 'help open'
> 
> Which is a little bit better.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: Don't leak local_err (Eric).

Thanks.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]