All of lore.kernel.org
 help / color / mirror / Atom feed
From: mmarek@suse.cz (Michal Marek)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCHv2] coccinelle: Add a script to find unnecessary ifs with no body
Date: Fri, 08 Nov 2013 14:52:40 +0100	[thread overview]
Message-ID: <527CECA8.5030408@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1311021748590.2261@hadrien>

On 2.11.2013 17:49, Julia Lawall wrote:
>> + at r depends on report || context@
>> +expression E;
>> +position p;
>> +@@
>> +if at p (E) {}
> 
> There should be a * in front of the if, to support context mode.

Josh, will you send a v3 with the above fix?

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [PATCHv2] coccinelle: Add a script to find unnecessary ifs with no body
Date: Fri, 08 Nov 2013 14:52:40 +0100	[thread overview]
Message-ID: <527CECA8.5030408@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1311021748590.2261@hadrien>

On 2.11.2013 17:49, Julia Lawall wrote:
>> +@r depends on report || context@
>> +expression E;
>> +position p;
>> +@@
>> +if@p (E) {}
> 
> There should be a * in front of the if, to support context mode.

Josh, will you send a v3 with the above fix?

Thanks,
Michal


  reply	other threads:[~2013-11-08 13:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 14:32 [Cocci] [PATCH] coccinelle: Add a script to find and remove unnecessary ifs with no body Josh Triplett
2013-11-02 14:32 ` Josh Triplett
2013-11-02 14:51 ` [Cocci] " Julia Lawall
2013-11-02 14:51   ` Julia Lawall
2013-11-02 15:05   ` [Cocci] " Josh Triplett
2013-11-02 15:05     ` Josh Triplett
2013-11-02 15:09     ` [Cocci] " Julia Lawall
2013-11-02 15:09       ` Julia Lawall
2013-11-02 15:15   ` [Cocci] [PATCHv2] coccinelle: Add a script to find " Josh Triplett
2013-11-02 15:15     ` Josh Triplett
2013-11-02 16:49     ` [Cocci] " Julia Lawall
2013-11-02 16:49       ` Julia Lawall
2013-11-08 13:52       ` Michal Marek [this message]
2013-11-08 13:52         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527CECA8.5030408@suse.cz \
    --to=mmarek@suse.cz \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.