From: "H. Peter Anvin" <hpa@zytor.com>
To: Vivek Goyal <vgoyal@redhat.com>, Baoquan He <bhe@redhat.com>
Cc: Robin Holt <robinmholt@gmail.com>,
mwhitehe@redhat.com, x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Robin Holt <robinmholt@linux.com>,
davej@fedoraproject.org, mingo@redhat.com,
"Eric W. Biederman" <ebiederm@xmission.com>,
rmk+kernel@arm.linux.org.uk, tglx@linutronix.de,
akpm@linux-foundation.org, chaowang@redhat.com
Subject: Re: [PATCH] x86: make reboot task only run on the appropriate processor
Date: Fri, 08 Nov 2013 08:12:00 -0800 [thread overview]
Message-ID: <527D0D50.6010607@zytor.com> (raw)
In-Reply-To: <20131108151416.GA13068@redhat.com>
On 11/08/2013 07:14 AM, Vivek Goyal wrote:
>
> Hi Bao,
>
> This patch fixes the issue for me too. I noticed that we have generic
> function migrate_to_reboot_cpu() to achieve what we want and rest of
> the reboot paths are using it. So how about using that function. I
> wrote the new patch below. It works for me. Can you please give it
> a try.
>
> Thanks
> Vivek
>
Is this path exercised for the kdump flow? migrate_to_reboot_cpu() is
unsafe in that case.
> Index: linux-2.6/kernel/kexec.c
> ===================================================================
> --- linux-2.6.orig/kernel/kexec.c 2013-10-16 00:30:50.000000000 -0400
> +++ linux-2.6/kernel/kexec.c 2013-11-08 21:34:02.492072375 -0500
> @@ -1676,6 +1676,7 @@ int kernel_kexec(void)
> #endif
> {
> kernel_restart_prepare(NULL);
> + migrate_to_reboot_cpu();
> printk(KERN_EMERG "Starting new kernel\n");
> machine_shutdown();
> }
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Vivek Goyal <vgoyal@redhat.com>, Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org, akpm@linux-foundation.org,
davej@fedoraproject.org, rmk+kernel@arm.linux.org.uk,
chaowang@redhat.com, mwhitehe@redhat.com,
kexec@lists.infradead.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Robin Holt <robinmholt@linux.com>,
Robin Holt <robinmholt@gmail.com>
Subject: Re: [PATCH] x86: make reboot task only run on the appropriate processor
Date: Fri, 08 Nov 2013 08:12:00 -0800 [thread overview]
Message-ID: <527D0D50.6010607@zytor.com> (raw)
In-Reply-To: <20131108151416.GA13068@redhat.com>
On 11/08/2013 07:14 AM, Vivek Goyal wrote:
>
> Hi Bao,
>
> This patch fixes the issue for me too. I noticed that we have generic
> function migrate_to_reboot_cpu() to achieve what we want and rest of
> the reboot paths are using it. So how about using that function. I
> wrote the new patch below. It works for me. Can you please give it
> a try.
>
> Thanks
> Vivek
>
Is this path exercised for the kdump flow? migrate_to_reboot_cpu() is
unsafe in that case.
> Index: linux-2.6/kernel/kexec.c
> ===================================================================
> --- linux-2.6.orig/kernel/kexec.c 2013-10-16 00:30:50.000000000 -0400
> +++ linux-2.6/kernel/kexec.c 2013-11-08 21:34:02.492072375 -0500
> @@ -1676,6 +1676,7 @@ int kernel_kexec(void)
> #endif
> {
> kernel_restart_prepare(NULL);
> + migrate_to_reboot_cpu();
> printk(KERN_EMERG "Starting new kernel\n");
> machine_shutdown();
> }
>
next prev parent reply other threads:[~2013-11-08 16:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 9:16 [PATCH] x86: make reboot task only run on the appropriate processor Baoquan He
2013-11-05 9:16 ` Baoquan He
2013-11-05 20:28 ` Vivek Goyal
2013-11-05 20:28 ` Vivek Goyal
2013-11-05 21:39 ` H. Peter Anvin
2013-11-05 21:39 ` H. Peter Anvin
2013-11-06 9:48 ` Baoquan He
2013-11-06 9:48 ` Baoquan He
2013-11-07 2:20 ` Baoquan He
2013-11-07 2:20 ` Baoquan He
2013-11-08 1:33 ` Dave Young
2013-11-08 1:33 ` Dave Young
2013-11-08 15:14 ` Vivek Goyal
2013-11-08 15:14 ` Vivek Goyal
2013-11-08 16:12 ` H. Peter Anvin [this message]
2013-11-08 16:12 ` H. Peter Anvin
2013-11-08 16:24 ` Vivek Goyal
2013-11-08 16:24 ` Vivek Goyal
2013-11-11 15:29 ` Vivek Goyal
2013-11-11 15:29 ` Vivek Goyal
2013-11-11 15:39 ` H. Peter Anvin
2013-11-11 15:39 ` H. Peter Anvin
2013-11-11 15:57 ` Vivek Goyal
2013-11-11 15:57 ` Vivek Goyal
2013-11-11 16:02 ` H. Peter Anvin
2013-11-11 16:02 ` H. Peter Anvin
2013-11-10 9:44 ` Baoquan He
2013-11-10 9:44 ` Baoquan He
2013-11-11 6:52 ` Baoquan He
2013-11-11 6:52 ` Baoquan He
2013-11-11 6:55 ` WANG Chao
2013-11-11 6:55 ` WANG Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527D0D50.6010607@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chaowang@redhat.com \
--cc=davej@fedoraproject.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mwhitehe@redhat.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robinmholt@gmail.com \
--cc=robinmholt@linux.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.