All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Cc: Lars Poeschel <poeschel@lemonage.de>
Subject: Re: [PATCH 2/2] iio: Drop scan_type from viperboard adc driver
Date: Sat, 09 Nov 2013 11:48:16 +0000	[thread overview]
Message-ID: <527E2100.408@kernel.org> (raw)
In-Reply-To: <1383421488-5167-2-git-send-email-pmeerw@pmeerw.net>

On 11/02/13 19:44, Peter Meerwald wrote:
> the driver does not support buffering, hence scan_type is not needed
> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Lars Poeschel <poeschel@lemonage.de>
We've left this sort of thing in in the past as it acts as documentation whilst
doing little harm.

Still in this driver there is nothing 'interesting' in the definition
so I've applied your patch to the togreg branch of iio.git

Thanks,

Jonathan
> ---
>  drivers/iio/adc/viperboard_adc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/adc/viperboard_adc.c b/drivers/iio/adc/viperboard_adc.c
> index 09727a7..94f404d 100644
> --- a/drivers/iio/adc/viperboard_adc.c
> +++ b/drivers/iio/adc/viperboard_adc.c
> @@ -42,11 +42,6 @@ struct vprbrd_adc {
>  	.indexed = 1,					\
>  	.channel = _index,				\
>  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),	\
> -	.scan_index = _index,				\
> -	.scan_type = {					\
> -		.sign = 'u',				\
> -		.realbits = 8,				\
> -		.storagebits = 8,			\
>  	},						\
>  }
>  
> @@ -73,7 +68,7 @@ static int vprbrd_iio_read_raw(struct iio_dev *iio_dev,
>  		mutex_lock(&vb->lock);
>  
>  		admsg->cmd = VPRBRD_ADC_CMD_GET;
> -		admsg->chan = chan->scan_index;
> +		admsg->chan = chan->channel;
>  		admsg->val = 0x00;
>  
>  		ret = usb_control_msg(vb->usb_dev,
> 

  reply	other threads:[~2013-11-09 10:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 19:44 [PATCH 1/2] iio: Fix sign extension table in mcp3422 driver Peter Meerwald
2013-11-02 19:44 ` [PATCH 2/2] iio: Drop scan_type from viperboard adc driver Peter Meerwald
2013-11-09 11:48   ` Jonathan Cameron [this message]
2013-11-09 13:52     ` Jonathan Cameron
2013-11-02 22:09 ` [PATCH 1/2] iio: Fix sign extension table in mcp3422 driver Angelo Compagnucci
2013-11-04 20:06   ` Jonathan Cameron
2013-11-05  7:57     ` Angelo Compagnucci
2013-11-05 13:28       ` Jonathan Cameron
2013-11-05 22:46         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527E2100.408@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.