Re: [PATCH 2/2] iio: Drop scan_type from viperboard adc driver

[Jonathan Cameron <jic23@kernel.org>]

On 11/09/13 11:48, Jonathan Cameron wrote:
> On 11/02/13 19:44, Peter Meerwald wrote:
>> the driver does not support buffering, hence scan_type is not needed
>>
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>> Cc: Lars Poeschel <poeschel@lemonage.de>
> We've left this sort of thing in in the past as it acts as documentation whilst
> doing little harm.
> 
> Still in this driver there is nothing 'interesting' in the definition
> so I've applied your patch to the togreg branch of iio.git
> 
> Thanks,
> 
> Jonathan
>> ---
>>  drivers/iio/adc/viperboard_adc.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/iio/adc/viperboard_adc.c b/drivers/iio/adc/viperboard_adc.c
>> index 09727a7..94f404d 100644
>> --- a/drivers/iio/adc/viperboard_adc.c
>> +++ b/drivers/iio/adc/viperboard_adc.c
>> @@ -42,11 +42,6 @@ struct vprbrd_adc {
>>  	.indexed = 1,					\
>>  	.channel = _index,				\
>>  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),	\
>> -	.scan_index = _index,				\
>> -	.scan_type = {					\
>> -		.sign = 'u',				\
>> -		.realbits = 8,				\
>> -		.storagebits = 8,			\
>>  	},						\
Too many brackets here - picked up by the autobuilders.

Now fixed up in my tree (note I now push to a testing branch specifically
to get build coverage) before I push out to the togreg branch.

thanks,

Jonathan
>>  }
>>  
>> @@ -73,7 +68,7 @@ static int vprbrd_iio_read_raw(struct iio_dev *iio_dev,
>>  		mutex_lock(&vb->lock);
>>  
>>  		admsg->cmd = VPRBRD_ADC_CMD_GET;
>> -		admsg->chan = chan->scan_index;
>> +		admsg->chan = chan->channel;
>>  		admsg->val = 0x00;
>>  
>>  		ret = usb_control_msg(vb->usb_dev,
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>