From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: Add RN104 SATA LEDs driven via NXP PCA9554 I2C to GPIO muxer
Date: Sun, 10 Nov 2013 00:59:08 +0100 [thread overview]
Message-ID: <527ECC4C.8080207@gmail.com> (raw)
In-Reply-To: <877gchmggw.fsf@natisbad.org>
On 11/09/2013 10:07 PM, Arnaud Ebalard wrote:
> NETGEAR ReadyNAS 104 has a NXP PCA9554 I2C to GPIO chip. Among the 8 GPIO
> lines the chip makes available, four are used on the device to control
> the SATA LEDs (the four remaining ones are used for SATA disk presence).
> This patch adds DT entries for NXP PCA9554 and the four SATA GPIO LEDs.
>
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
> ---
[...]
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> index b0b32f5..1efc871 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> @@ -123,6 +123,13 @@
> fan_startv = <1>;
> pwm_polarity = <0>;
> };
> +
> + pca9554: pca9554 at 23 {
> + compatible = "nxp,pca9554";
> + gpio-controller;
> + #gpio-cells = <2>;
> + reg = <0x23>;
> + };
> };
> };
> };
> @@ -154,6 +161,30 @@
> gpios = <&gpio2 0 1>; /* GPIO 64 Active Low */
> linux,default-trigger = "keep";
> };
> +
> + sata1_led {
> + label = "rn104:blue:sata1";
> + gpios = <&pca9554 0 1>; /* Active Low */
Same comment as for ReadyNAS 2120 patch:
#include <dt-bindings/gpio/gpio.h> and use GPIO_ACTIVE_HIGH/LOW.
Sebastian
> + default-state = "off";
> + };
> +
> + sata2_led {
> + label = "rn104:blue:sata2";
> + gpios = <&pca9554 1 1>; /* Active Low */
> + default-state = "off";
> + };
> +
> + sata3_led {
> + label = "rn104:blue:sata3";
> + gpios = <&pca9554 2 1>; /* Active Low */
> + default-state = "off";
> + };
> +
> + sata4_led {
> + label = "rn104:blue:sata4";
> + gpios = <&pca9554 3 1>; /* Active Low */
> + default-state = "off";
> + };
> };
>
> gpio_keys {
>
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: mvebu: Add RN104 SATA LEDs driven via NXP PCA9554 I2C to GPIO muxer
Date: Sun, 10 Nov 2013 00:59:08 +0100 [thread overview]
Message-ID: <527ECC4C.8080207@gmail.com> (raw)
In-Reply-To: <877gchmggw.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
On 11/09/2013 10:07 PM, Arnaud Ebalard wrote:
> NETGEAR ReadyNAS 104 has a NXP PCA9554 I2C to GPIO chip. Among the 8 GPIO
> lines the chip makes available, four are used on the device to control
> the SATA LEDs (the four remaining ones are used for SATA disk presence).
> This patch adds DT entries for NXP PCA9554 and the four SATA GPIO LEDs.
>
> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
> ---
[...]
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> index b0b32f5..1efc871 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> @@ -123,6 +123,13 @@
> fan_startv = <1>;
> pwm_polarity = <0>;
> };
> +
> + pca9554: pca9554@23 {
> + compatible = "nxp,pca9554";
> + gpio-controller;
> + #gpio-cells = <2>;
> + reg = <0x23>;
> + };
> };
> };
> };
> @@ -154,6 +161,30 @@
> gpios = <&gpio2 0 1>; /* GPIO 64 Active Low */
> linux,default-trigger = "keep";
> };
> +
> + sata1_led {
> + label = "rn104:blue:sata1";
> + gpios = <&pca9554 0 1>; /* Active Low */
Same comment as for ReadyNAS 2120 patch:
#include <dt-bindings/gpio/gpio.h> and use GPIO_ACTIVE_HIGH/LOW.
Sebastian
> + default-state = "off";
> + };
> +
> + sata2_led {
> + label = "rn104:blue:sata2";
> + gpios = <&pca9554 1 1>; /* Active Low */
> + default-state = "off";
> + };
> +
> + sata3_led {
> + label = "rn104:blue:sata3";
> + gpios = <&pca9554 2 1>; /* Active Low */
> + default-state = "off";
> + };
> +
> + sata4_led {
> + label = "rn104:blue:sata4";
> + gpios = <&pca9554 3 1>; /* Active Low */
> + default-state = "off";
> + };
> };
>
> gpio_keys {
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-09 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 21:07 [PATCH] ARM: mvebu: Add RN104 SATA LEDs driven via NXP PCA9554 I2C to GPIO muxer Arnaud Ebalard
2013-11-09 21:07 ` Arnaud Ebalard
2013-11-09 23:59 ` Sebastian Hesselbarth [this message]
2013-11-09 23:59 ` Sebastian Hesselbarth
2013-11-10 0:50 ` Arnaud Ebalard
2013-11-10 0:50 ` Arnaud Ebalard
2013-11-11 20:07 ` Arnaud Ebalard
2013-11-11 20:07 ` Arnaud Ebalard
2013-11-11 20:22 ` Sebastian Hesselbarth
2013-11-11 20:22 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527ECC4C.8080207@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.