From: Ionut Nicu <ioan.nicu.ext-OYasijW0DpE@public.gmane.org>
To: ext Pantelis Antoniou
<panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Matt Porter <matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Koen Kooi
<koen-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>,
Alison Chaiken
<Alison_Chaiken-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
Dinh Nguyen <dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jan Lubbe <jluebbe-H4yykcOXDpCzQB+pC5nmwQ@public.gmane.org>,
Alexander Sverdlin
<alexander.sverdlin-OYasijW0DpE@public.gmane.org>,
Michael Stickel <ms-g5CePrrZ5ROELgA04lAiVw@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Dirk Behme <dirk.behme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alan Tull
<delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Michael Bohan <mbohan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>,
Matt Ranostay <mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Joel Becker <jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc
Date: Mon, 11 Nov 2013 11:22:07 +0100 [thread overview]
Message-ID: <5280AFCF.8050208@nsn.com> (raw)
In-Reply-To: <1383923170-24914-4-git-send-email-panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
Hi,
On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
> Add a runtime interface to /proc to enable generic device tree overlay
> usage.
>
> +
> + /* start at 256K at first */
> + if (od->alloc == 0)
> + od->alloc = SZ_256K / 2;
> +
Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
the code will not build.
> + rcu_read_lock();
> + idr_for_each_entry(&overlay_idr, od, id) {
> + seq_printf(m, "%d: %d bytes", id, od->size);
For od->size we should use "%zu", otherwise there will be a compilation warning.
At least I get one on mips64...
Otherwise, I've tested this and it works fine for me also.
Thanks,
Ionut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ionut Nicu <ioan.nicu.ext@nsn.com>
To: ext Pantelis Antoniou <panto@antoniou-consulting.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <robherring2@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Matt Porter <matt.porter@linaro.org>,
Koen Kooi <koen@dominion.thruhere.net>,
Alison Chaiken <Alison_Chaiken@mentor.com>,
Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
Michael Stickel <ms@mycable.de>,
Guenter Roeck <linux@roeck-us.net>,
Dirk Behme <dirk.behme@gmail.com>,
Alan Tull <delicious.quinoa@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Michael Bohan <mbohan@codeaurora.org>,
Michal Simek <monstr@monstr.eu>,
Matt Ranostay <mranostay@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc
Date: Mon, 11 Nov 2013 11:22:07 +0100 [thread overview]
Message-ID: <5280AFCF.8050208@nsn.com> (raw)
In-Reply-To: <1383923170-24914-4-git-send-email-panto@antoniou-consulting.com>
Hi,
On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
> Add a runtime interface to /proc to enable generic device tree overlay
> usage.
>
> +
> + /* start at 256K at first */
> + if (od->alloc == 0)
> + od->alloc = SZ_256K / 2;
> +
Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
the code will not build.
> + rcu_read_lock();
> + idr_for_each_entry(&overlay_idr, od, id) {
> + seq_printf(m, "%d: %d bytes", id, od->size);
For od->size we should use "%zu", otherwise there will be a compilation warning.
At least I get one on mips64...
Otherwise, I've tested this and it works fine for me also.
Thanks,
Ionut
next prev parent reply other threads:[~2013-11-11 10:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 15:06 [PATCH v3 0/3] Introducing Device Tree Overlays Pantelis Antoniou
2013-11-08 15:06 ` Pantelis Antoniou
2013-11-08 15:06 ` [PATCH v3 1/3] OF: Introduce Device Tree resolve support Pantelis Antoniou
[not found] ` <1383923170-24914-2-git-send-email-panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-11-11 18:17 ` Grant Likely
2013-11-11 18:17 ` Grant Likely
[not found] ` <20131111181739.06BC5C42348-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-11-12 8:28 ` Pantelis Antoniou
2013-11-12 8:28 ` Pantelis Antoniou
[not found] ` <F60B2232-94D0-41C6-8D79-5A28FA282D4E-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-11-13 1:39 ` Grant Likely
2013-11-13 1:39 ` Grant Likely
[not found] ` <20131113013936.E591FC419FB-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-11-13 9:06 ` Pantelis Antoniou
2013-11-13 9:06 ` Pantelis Antoniou
2013-11-08 15:06 ` [PATCH v3 2/3] OF: Introduce DT overlay support Pantelis Antoniou
2013-11-08 19:12 ` Guenter Roeck
2013-11-11 18:42 ` Grant Likely
2013-11-11 18:42 ` Grant Likely
[not found] ` <20131111184245.D569DC4234A-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-11-12 9:30 ` Pantelis Antoniou
2013-11-12 9:30 ` Pantelis Antoniou
2013-11-14 1:31 ` Grant Likely
[not found] ` <20131114013124.7DD0AC404DF-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-11-14 10:01 ` Pantelis Antoniou
2013-11-14 10:01 ` Pantelis Antoniou
[not found] ` < 20131111184245.D569DC4234A@trevor.secretlab.ca>
[not found] ` < ED51965C-6EC8-48AE-A59C-CD09FFD57731@antoniou-consulting.com>
[not found] ` < 20131114013124.7DD0AC404DF@trevor.secretlab.ca>
[not found] ` < E4922A5F-11B3-4167-91EF-C0D5F3F77D40@antoniou-consulting.com>
[not found] ` <E4922A5F-11B3-4167-91EF-C0D5F3F77D40-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-11-14 21:22 ` Grant Likely
2013-11-14 21:22 ` Grant Likely
[not found] ` <20131114212206.EAD1BC402B4-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-11-15 8:34 ` Pantelis Antoniou
2013-11-15 8:34 ` Pantelis Antoniou
[not found] ` < 20131114212206.EAD1BC402B4@trevor.secretlab.ca>
[not found] ` < D048F1EA-B78C-4B10-9A6D-726A17036B42@antoniou-consulting.com>
[not found] ` <D048F1EA-B78C-4B10-9A6D-726A17036B42-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-11-15 16:13 ` Grant Likely
2013-11-15 16:13 ` Grant Likely
2013-11-08 15:06 ` [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc Pantelis Antoniou
2013-11-08 20:00 ` Guenter Roeck
[not found] ` <1383923170-24914-4-git-send-email-panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-11-11 10:22 ` Ionut Nicu [this message]
2013-11-11 10:22 ` Ionut Nicu
[not found] ` <5280AFCF.8050208-OYasijW0DpE@public.gmane.org>
2013-11-11 12:30 ` Pantelis Antoniou
2013-11-11 12:30 ` Pantelis Antoniou
2013-11-11 18:47 ` Grant Likely
2013-11-11 18:47 ` Grant Likely
[not found] ` <20131111184736.3DE20C4234E-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-11-12 8:40 ` Pantelis Antoniou
2013-11-12 8:40 ` Pantelis Antoniou
[not found] ` <86657251-2872-4FB2-B71A-519A685B458A-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-11-12 15:27 ` Matt Porter
2013-11-12 15:27 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280AFCF.8050208@nsn.com \
--to=ioan.nicu.ext-oyasijw0dpe@public.gmane.org \
--cc=Alison_Chaiken-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
--cc=alexander.sverdlin-OYasijW0DpE@public.gmane.org \
--cc=delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dirk.behme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org \
--cc=jluebbe-H4yykcOXDpCzQB+pC5nmwQ@public.gmane.org \
--cc=koen-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mbohan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org \
--cc=mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ms-g5CePrrZ5ROELgA04lAiVw@public.gmane.org \
--cc=panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.