Re: [PATCH v5 0/7] gpio: daVinci: cleanup and feature enhancement

[Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>]

Hi Prabhakar Lad,

On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
> From: KV Sujith <sujithkv-l0cyMroinI0@public.gmane.org>
>
> This patch series does the following
> 1> Ports the driver to use irqdomain.
> 2> Adds dt binding support for gpio-davinci.
> 3> Adds DA850 dt support goio.
>
> Changes for v5:
> 1: Fixed review comments pointed by Grygorii.
> 2: Dropped the fixup patch
>
> This patch series is based on following fixup series
> http://us.generation-nt.com/answer/patch-0-2-davinci-gpio-fixes-help-212978272.html

Few comments to this series - the rest looks ok to me.
  Hope it will pass review of bindings :P

>
> KV Sujith (3):
>    gpio: davinci: add OF support
>    ARM: davinci: da850: add GPIO DT node
>    ARM: davinci: da850 evm: add GPIO pinumux entries DT node
>
> Lad, Prabhakar (4):
>    gpio: davinci: remove unnecessary printk
>    gpio: davinci: use readl/writel instead of __raw_*
>    gpio: davinci: use irqdomain
>    gpio: davinci: remove unused variable intc_irq_num
>
>   .../devicetree/bindings/gpio/gpio-davinci.txt      |   39 +++++
>   arch/arm/boot/dts/da850-evm.dts                    |   20 +++
>   arch/arm/boot/dts/da850.dtsi                       |   14 ++
>   arch/arm/mach-davinci/da830.c                      |    1 -
>   arch/arm/mach-davinci/da850.c                      |    1 -
>   arch/arm/mach-davinci/dm355.c                      |    1 -
>   arch/arm/mach-davinci/dm365.c                      |    1 -
>   arch/arm/mach-davinci/dm644x.c                     |    1 -
>   arch/arm/mach-davinci/dm646x.c                     |    1 -
>   drivers/gpio/gpio-davinci.c                        |  170 +++++++++++++-------
>   include/linux/platform_data/gpio-davinci.h         |    3 +-
>   11 files changed, 185 insertions(+), 67 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
>
Regards,
- grygorii