From: Stephen Warren <swarren@wwwdotorg.org>
To: Felipe Balbi <balbi@ti.com>, mturquette@linaro.org
Cc: Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
james.hogan@imgtec.com, luca@coelho.fi
Subject: Re: [PATCH] clk: add flags to distinguish xtal clocks
Date: Mon, 11 Nov 2013 09:27:58 -0700 [thread overview]
Message-ID: <5281058E.5050607@wwwdotorg.org> (raw)
In-Reply-To: <1383933648-28595-1-git-send-email-balbi@ti.com>
On 11/08/2013 11:00 AM, Felipe Balbi wrote:
> From: Luciano Coelho <luca@coelho.fi>
>
> Add a flag that indicate whether the clock is a crystal or not.
>
> Additionally, parse a new device tree binding in clk-fixed-rate to set
> this flag.
>
> If clock-xtal isn't set, the clock framework will assume clock to be
> generated by an oscillator. There's only one user for this binding
> right now which is Texas Instruments' WiLink devices which need to know
> details about the clock in order to initialize the underlying WiFi HW
> correctly.
Why on earth does it care? Surely the WiFi HW doesn't care about
crystal-vs-non-crystal, but rather some facet of the clock signal that
the type of source implies. Shouldn't the DT property describe that
facet of the signal, rather than the reason why it has that facet?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: add flags to distinguish xtal clocks
Date: Mon, 11 Nov 2013 09:27:58 -0700 [thread overview]
Message-ID: <5281058E.5050607@wwwdotorg.org> (raw)
In-Reply-To: <1383933648-28595-1-git-send-email-balbi@ti.com>
On 11/08/2013 11:00 AM, Felipe Balbi wrote:
> From: Luciano Coelho <luca@coelho.fi>
>
> Add a flag that indicate whether the clock is a crystal or not.
>
> Additionally, parse a new device tree binding in clk-fixed-rate to set
> this flag.
>
> If clock-xtal isn't set, the clock framework will assume clock to be
> generated by an oscillator. There's only one user for this binding
> right now which is Texas Instruments' WiLink devices which need to know
> details about the clock in order to initialize the underlying WiFi HW
> correctly.
Why on earth does it care? Surely the WiFi HW doesn't care about
crystal-vs-non-crystal, but rather some facet of the clock signal that
the type of source implies. Shouldn't the DT property describe that
facet of the signal, rather than the reason why it has that facet?
next prev parent reply other threads:[~2013-11-11 16:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 21:05 [RFC] clk: add flags to distinguish xtal clocks Luciano Coelho
2013-07-04 21:05 ` Luciano Coelho
2013-07-04 22:25 ` Mike Turquette
2013-07-04 22:37 ` Luciano Coelho
2013-07-04 22:37 ` Luciano Coelho
2013-07-04 23:19 ` Mike Turquette
2013-07-05 7:54 ` Luciano Coelho
2013-07-05 7:54 ` Luciano Coelho
2013-07-29 13:50 ` Luciano Coelho
2013-07-29 13:50 ` Luciano Coelho
2013-10-07 7:44 ` Mike Turquette
2013-10-08 15:27 ` Felipe Balbi
2013-10-08 15:27 ` Felipe Balbi
2013-10-16 10:24 ` Luca Coelho
2013-10-16 10:24 ` Luca Coelho
2013-10-23 9:24 ` Mike Turquette
2013-10-23 9:24 ` Mike Turquette
2013-10-23 11:35 ` Luca Coelho
2013-10-23 11:35 ` Luca Coelho
2013-11-08 18:00 ` [PATCH] " Felipe Balbi
2013-11-08 18:00 ` Felipe Balbi
2013-11-08 18:00 ` Felipe Balbi
2013-11-08 19:16 ` Luca Coelho
2013-11-08 19:16 ` Luca Coelho
2013-11-10 11:37 ` Maxime Ripard
2013-11-10 11:37 ` Maxime Ripard
2013-11-11 19:42 ` Felipe Balbi
2013-11-11 19:42 ` Felipe Balbi
2013-11-11 19:42 ` Felipe Balbi
2013-11-11 19:50 ` Luca Coelho
2013-11-11 19:50 ` Luca Coelho
2013-11-11 20:59 ` Maxime Ripard
2013-11-11 20:59 ` Maxime Ripard
2013-11-12 8:05 ` Luca Coelho
2013-11-12 8:05 ` Luca Coelho
2013-11-13 14:40 ` Maxime Ripard
2013-11-13 14:40 ` Maxime Ripard
2013-11-11 20:54 ` Maxime Ripard
2013-11-11 20:54 ` Maxime Ripard
2013-11-11 16:27 ` Stephen Warren [this message]
2013-11-11 16:27 ` Stephen Warren
2013-11-11 19:43 ` Felipe Balbi
2013-11-11 19:43 ` Felipe Balbi
2013-11-11 19:43 ` Felipe Balbi
2013-07-05 13:12 ` [RFC] " James Hogan
2013-07-05 13:12 ` James Hogan
2013-07-05 13:21 ` Felipe Balbi
2013-07-05 13:21 ` Felipe Balbi
2013-07-05 13:22 ` Luciano Coelho
2013-07-05 13:22 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5281058E.5050607@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.